Linux-ARM-MSM Archive on lore.kernel.org
 help / color / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>,
	Taniya Das <tdas@codeaurora.org>
Cc: David Brown <david.brown@linaro.org>,
	Rajendra Nayak <rnayak@codeaurora.org>,
	linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andy Gross <agross@kernel.org>,
	devicetree@vger.kernel.org, robh@kernel.org, robh+dt@kernel.org,
	Taniya Das <tdas@codeaurora.org>
Subject: Re: [PATCH v2 3/3] clk: qcom: camcc: Add camera clock controller driver for SC7180
Date: Tue, 13 Oct 2020 18:59:11 -0700
Message-ID: <160264075146.310579.8765964662995263828@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1602609110-11504-4-git-send-email-tdas@codeaurora.org>

Quoting Taniya Das (2020-10-13 10:11:50)
> diff --git a/drivers/clk/qcom/camcc-sc7180.c b/drivers/clk/qcom/camcc-sc7180.c
> new file mode 100644
> index 0000000..e954d21
> --- /dev/null
> +++ b/drivers/clk/qcom/camcc-sc7180.c
> @@ -0,0 +1,1737 @@
[...]
> +
> +enum {
> +       P_BI_TCXO,
> +       P_CAM_CC_PLL0_OUT_EVEN,
> +       P_CAM_CC_PLL1_OUT_EVEN,
> +       P_CAM_CC_PLL2_OUT_AUX,
> +       P_CAM_CC_PLL2_OUT_EARLY,
> +       P_CAM_CC_PLL3_OUT_MAIN,
> +       P_CORE_BI_PLL_TEST_SE,
> +};
> +
> +static struct pll_vco agera_vco[] = {

Can this be const?

> +       { 600000000, 3300000000, 0 },
> +};
> +
> +static struct pll_vco fabia_vco[] = {

Can this be const?

> +       { 249600000, 2000000000, 0 },
> +};
> +
[...]
> +
> +static int cam_cc_sc7180_probe(struct platform_device *pdev)
> +{
> +       struct regmap *regmap;
> +       int ret;
> +
> +       pm_runtime_enable(&pdev->dev);
> +       ret = pm_clk_create(&pdev->dev);
> +       if (ret)
> +               return ret;
> +
> +       ret = pm_clk_add(&pdev->dev, "xo");
> +       if (ret < 0) {
> +               dev_err(&pdev->dev, "Failed to acquire XO clock\n");
> +               goto disable_pm_runtime;
> +       }
> +
> +       ret = pm_clk_add(&pdev->dev, "iface");
> +       if (ret < 0) {
> +               dev_err(&pdev->dev, "Failed to acquire iface clock\n");
> +               goto disable_pm_runtime;
> +       }
> +
> +       ret = pm_clk_runtime_resume(&pdev->dev);
> +       if (ret) {
> +               dev_err(&pdev->dev, "pm runtime resume failed\n");
> +               goto destroy_pm_clk;
> +       }
> +
> +       regmap = qcom_cc_map(pdev, &cam_cc_sc7180_desc);
> +       if (IS_ERR(regmap)) {
> +               ret = PTR_ERR(regmap);
> +               goto destroy_pm_clk;
> +       }
> +
> +       clk_fabia_pll_configure(&cam_cc_pll0, regmap, &cam_cc_pll0_config);
> +       clk_fabia_pll_configure(&cam_cc_pll1, regmap, &cam_cc_pll1_config);
> +       clk_agera_pll_configure(&cam_cc_pll2, regmap, &cam_cc_pll2_config);
> +       clk_fabia_pll_configure(&cam_cc_pll3, regmap, &cam_cc_pll3_config);
> +
> +       ret = qcom_cc_really_probe(pdev, &cam_cc_sc7180_desc, regmap);
> +       if (ret) {
> +               dev_err(&pdev->dev, "Failed to register CAM CC clocks\n");
> +               goto suspend_pm_runtime;

ret is non-zero here

> +       }
> +
> +suspend_pm_runtime:
> +       ret = pm_clk_runtime_suspend(&pdev->dev);

But then it is overwritten here.

> +       if (ret)
> +               dev_err(&pdev->dev, "pm runtime suspend failed\n");
> +
> +       return 0;

And we return 0 when there was a failure to probe the clks?

> +
> +destroy_pm_clk:
> +       pm_clk_destroy(&pdev->dev);
> +
> +disable_pm_runtime:
> +       pm_runtime_disable(&pdev->dev);
> +
> +       return ret;
> +}

  reply index

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-13 17:11 [PATCH v2 0/3] Add Camera " Taniya Das
2020-10-13 17:11 ` [PATCH v2 1/3] clk: qcom: clk-alpha-pll: Add support for controlling Agera PLLs Taniya Das
2020-10-14  2:07   ` Stephen Boyd
2020-10-16 18:38     ` Taniya Das
2020-10-13 17:11 ` [PATCH v2 2/3] dt-bindings: clock: Add YAML schemas for the QCOM Camera clock bindings Taniya Das
2020-10-14  2:09   ` Stephen Boyd
2020-10-16 18:39     ` Taniya Das
2020-10-16 17:25   ` Rob Herring
2020-10-13 17:11 ` [PATCH v2 3/3] clk: qcom: camcc: Add camera clock controller driver for SC7180 Taniya Das
2020-10-14  1:59   ` Stephen Boyd [this message]
2020-10-16 18:40     ` Taniya Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=160264075146.310579.8765964662995263828@swboyd.mtv.corp.google.com \
    --to=sboyd@kernel.org \
    --cc=agross@kernel.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=rnayak@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=tdas@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-MSM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \
		linux-arm-msm@vger.kernel.org
	public-inbox-index linux-arm-msm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git