From: Stephen Boyd <swboyd@chromium.org>
To: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>,
agross@kernel.org, bjorn.andersson@linaro.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
rohitkr@codeaurora.org, srinivas.kandagatla@linaro.org
Cc: V Sujith Kumar Reddy <vsujithk@codeaurora.org>,
Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for HDMI
Date: Thu, 14 Jan 2021 19:18:17 -0800 [thread overview]
Message-ID: <161068069765.3661239.6061499369110570958@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1601448168-18396-3-git-send-email-srivasam@codeaurora.org>
Quoting Srinivasa Rao Mandadapu (2020-09-29 23:42:48)
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> index 5724982..850b43e 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> @@ -231,6 +231,7 @@
>
> audio-jack = <&alc5682>;
>
> + #sound-dai-cells = <0>;
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -257,6 +258,17 @@
> sound-dai = <&max98357a>;
> };
> };
Can you please add a newline here?
> + dai-link@2 {
> + link-name = "MultiMedia2";
> + reg = <2>;
> + cpu {
> + sound-dai = <&lpass_cpu 2>;
> + };
> +
> + codec {
> + sound-dai = <&msm_dp>;
> + };
> + };
> };
> };
>
> @@ -782,6 +794,9 @@ hp_i2c: &i2c9 {
> reg = <MI2S_SECONDARY>;
> qcom,playback-sd-lines = <0>;
> };
Can you please add a newline here?
> + hdmi-primary@0 {
This should be hdmi-primary@2 {
Or a more generic node name should be devised. dai@2 perhaps?
> + reg = <LPASS_DP_RX>;
> + };
> };
>
next prev parent reply other threads:[~2021-01-15 3:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 6:42 [PATCH v3 0/2] Qualcomm's lpass device tree changes Srinivasa Rao Mandadapu
2020-09-30 6:42 ` [PATCH v3 1/2] arm64: dts: qcom: sc7180: Update lpass cpu node for audio over dp Srinivasa Rao Mandadapu
2020-11-30 11:02 ` Srinivas Kandagatla
2020-09-30 6:42 ` [PATCH v3 2/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for HDMI Srinivasa Rao Mandadapu
2020-11-30 11:02 ` Srinivas Kandagatla
2021-01-15 3:18 ` Stephen Boyd [this message]
2021-07-21 4:44 ` Stephen Boyd
2021-07-21 8:44 ` Srinivasa Rao Mandadapu
2020-11-30 16:53 ` [PATCH v3 0/2] Qualcomm's lpass device tree changes Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161068069765.3661239.6061499369110570958@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=srivasam@codeaurora.org \
--cc=vsujithk@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).