From: Stephen Boyd <swboyd@chromium.org>
To: Krishna Manikandan <mkrishn@codeaurora.org>,
linux-arm-msm@vger.kernel.org
Cc: Krishna Manikandan <mkrishn@codeaurora.org>,
kalyan_t@codeaurora.org, tanmay@codeaurora.org,
abhinavk@codeaurora.org, robdclark@gmail.com,
bjorn.andersson@linaro.org, vinod.koul@linaro.org,
rnayak@codeaurora.org, dianders@chromium.org,
sibis@codeaurora.org, Vara Reddy <varar@codeaurora.org>,
Kuogee Hsieh <khsieh@codeaurora.org>
Subject: Re: [PATCH v10 4/4] dt-bindings: msm/dp: Add bindings of MSM DisplayPort controller
Date: Fri, 05 Feb 2021 11:02:08 -0800 [thread overview]
Message-ID: <161255172811.76967.16401619378965156134@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1612420939-15502-4-git-send-email-mkrishn@codeaurora.org>
Quoting Krishna Manikandan (2021-02-03 22:42:19)
> Add bindings for Snapdragon DisplayPort controller driver.
>
> Signed-off-by: Chandan Uddaraju <chandanu@codeaurora.org>
> Signed-off-by: Vara Reddy <varar@codeaurora.org>
> Signed-off-by: Tanmay Shah <tanmay@codeaurora.org>
> Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org>
>
[...]
>
> Changes in v11:
> - add ports required of both #address-cells and #size-cells
> - add required operating-points-v2
> - add required #sound-dai-cells
> - add required power-domains
> - update maintainer list
Where's that maintainer file update?
> ---
> .../bindings/display/msm/dp-controller.yaml | 157 +++++++++++++++++++++
> .../bindings/display/msm/dpu-sc7180.yaml | 10 ++
> 2 files changed, 167 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> new file mode 100644
> index 0000000..2b71c7a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> @@ -0,0 +1,157 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MSM Display Port Controller
> +
> +maintainers:
> + - Chandan Uddaraju <chandanu@codeaurora.org>
This email is bouncing. Please remove Chandan.
> + - Vara Reddy <varar@codeaurora.org>
> + - Kuogee Hsieh <khsieh@codeaurora.org>
> +
> +description: |
> + Device tree bindings for DisplayPort host controller for MSM targets
> + that are compatible with VESA DisplayPort interface specification.
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,sc7180-dp
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: AHB clock to enable register access
> + - description: Display Port AUX clock
> + - description: Display Port Link clock
> + - description: Link interface clock between DP and PHY
> + - description: Display Port Pixel clock
> +
> + clock-names:
> + items:
> + - const: core_iface
> + - const: core_aux
> + - const: ctrl_link
> + - const: ctrl_link_iface
> + - const: stream_pixel
> +
> + phys:
> + maxItems: 1
> +
> + phy-names:
> + items:
> + - const: dp
> +
> + operating-points-v2:
> + maxItems: 1
> +
> + power-domains:
> + maxItems: 1
> +
> + "#sound-dai-cells":
> + const: 0
> +
> + ports:
> + type: object
> + description: |
> + A ports node with endpoint definitions as defined in
> + Documentation/devicetree/bindings/media/video-interfaces.txt.
> + properties:
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> + port@0:
> + type: object
> + description: Input endpoint of the controller
> +
> + port@1:
> + type: object
> + description: Output endpoint of the controller
> +
> + required:
> + - "#address-cells"
> + - "#size-cells"
> +
> + additionalProperties: false
> +
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - phys
> + - phy-names
> + - "#sound-dai-cells"
> + - power-domains
> + - ports
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/clock/qcom,dispcc-sc7180.h>
> + #include <dt-bindings/power/qcom-aoss-qmp.h>
> + #include <dt-bindings/power/qcom-rpmpd.h>
> +
> + mdss@ae00000 {
mdss is not a standard node name. Maybe 'subsystem'?
> + #address-cells = <2>;
> + #size-cells = <2>;
> + reg = <0xae00000 0x1000>, /* mdss */
> + <0xae90000 0x1400>; /* dp */
This second reg property shouldn't be here.
> + reg-names = "mdss", "dp";
> +
> + displayport-controller@ae90000 {
next prev parent reply other threads:[~2021-02-05 19:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 6:42 [PATCH v10 1/4] dt-bindings: msm: disp: add yaml schemas for DPU bindings Krishna Manikandan
2021-02-04 6:42 ` [PATCH v10 2/4] dt-bindings: msm: dsi: add yaml schemas for DSI bindings Krishna Manikandan
2021-02-05 22:34 ` Stephen Boyd
2021-02-09 10:53 ` mkrishn
2021-02-10 6:02 ` Stephen Boyd
2021-02-04 6:42 ` [PATCH v10 3/4] dt-bindings: msm: dsi: add yaml schemas for DSI PHY bindings Krishna Manikandan
2021-02-05 19:08 ` Stephen Boyd
2021-02-04 6:42 ` [PATCH v10 4/4] dt-bindings: msm/dp: Add bindings of MSM DisplayPort controller Krishna Manikandan
2021-02-05 19:02 ` Stephen Boyd [this message]
2021-02-05 20:55 ` khsieh
2021-02-05 22:38 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161255172811.76967.16401619378965156134@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=abhinavk@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=kalyan_t@codeaurora.org \
--cc=khsieh@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=mkrishn@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=robdclark@gmail.com \
--cc=sibis@codeaurora.org \
--cc=tanmay@codeaurora.org \
--cc=varar@codeaurora.org \
--cc=vinod.koul@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).