From: Stephen Boyd <sboyd@kernel.org>
To: Subbaraman Narayanamurthy <subbaram@codeaurora.org>,
linux-kernel@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org,
David Collins <collinsd@codeaurora.org>,
Subbaraman Narayanamurthy <subbaram@codeaurora.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] spmi: spmi-pmic-arb: Fix hw_irq overflow
Date: Mon, 08 Feb 2021 14:07:12 -0800 [thread overview]
Message-ID: <161282203270.4168818.14030280893762596656@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1612812784-26369-1-git-send-email-subbaram@codeaurora.org>
Quoting Subbaraman Narayanamurthy (2021-02-08 11:33:04)
> Currently, when handling the SPMI summary interrupt, the hw_irq
> number is calculated based on SID, Peripheral ID, IRQ index and
> APID. This is then passed to irq_find_mapping() to see if a
> mapping exists for this hw_irq and if available, invoke the
> interrupt handler. Since the IRQ index uses an "int" type, hw_irq
> which is of unsigned long data type can take a large value when
> SID has its MSB set to 1 and the type conversion happens. Because
> of this, irq_find_mapping() returns 0 as there is no mapping
> for this hw_irq. This ends up invoking cleanup_irq() as if
> the interrupt is spurious whereas it is actually a valid
> interrupt. Fix this by using the proper data type (u32) for id.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Subbaraman Narayanamurthy <subbaram@codeaurora.org>
> ---
Applied to spmi-next
next prev parent reply other threads:[~2021-02-08 22:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 19:33 [PATCH] spmi: spmi-pmic-arb: Fix hw_irq overflow Subbaraman Narayanamurthy
2021-02-08 22:07 ` Stephen Boyd [this message]
2021-03-01 19:59 ` patchwork-bot+linux-arm-msm
-- strict thread matches above, loose matches on Subject: below --
2021-01-23 2:45 Subbaraman Narayanamurthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161282203270.4168818.14030280893762596656@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=collinsd@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=subbaram@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).