linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] regulator: qcom-rpmh: fix pm8009 ldo7
@ 2021-02-11  3:49 Jonathan Marek
  2021-02-11  4:36 ` Vinod Koul
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Jonathan Marek @ 2021-02-11  3:49 UTC (permalink / raw)
  To: linux-arm-msm
  Cc: Andy Gross, Bjorn Andersson, Liam Girdwood, Mark Brown,
	Vinod Koul, open list:VOLTAGE AND CURRENT REGULATOR FRAMEWORK

Use the correct name to avoid ldo7 commands being sent to ldo6's address.

Fixes: 06369bcc15a1 ("regulator: qcom-rpmh: Add support for SM8150")
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
---
 drivers/regulator/qcom-rpmh-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c
index 05f1b4e150f4..043dc2fd39eb 100644
--- a/drivers/regulator/qcom-rpmh-regulator.c
+++ b/drivers/regulator/qcom-rpmh-regulator.c
@@ -937,7 +937,7 @@ static const struct rpmh_vreg_init_data pm8009_vreg_data[] = {
 	RPMH_VREG("ldo4",   "ldo%s4",  &pmic5_nldo,      "vdd-l4"),
 	RPMH_VREG("ldo5",   "ldo%s5",  &pmic5_pldo,      "vdd-l5-l6"),
 	RPMH_VREG("ldo6",   "ldo%s6",  &pmic5_pldo,      "vdd-l5-l6"),
-	RPMH_VREG("ldo7",   "ldo%s6",  &pmic5_pldo_lv,   "vdd-l7"),
+	RPMH_VREG("ldo7",   "ldo%s7",  &pmic5_pldo_lv,   "vdd-l7"),
 	{},
 };
 
-- 
2.26.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] regulator: qcom-rpmh: fix pm8009 ldo7
  2021-02-11  3:49 [PATCH] regulator: qcom-rpmh: fix pm8009 ldo7 Jonathan Marek
@ 2021-02-11  4:36 ` Vinod Koul
  2021-02-11 15:39 ` Mark Brown
  2021-03-01 19:59 ` patchwork-bot+linux-arm-msm
  2 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2021-02-11  4:36 UTC (permalink / raw)
  To: Jonathan Marek
  Cc: linux-arm-msm, Andy Gross, Bjorn Andersson, Liam Girdwood,
	Mark Brown, open list:VOLTAGE AND CURRENT REGULATOR FRAMEWORK

On 10-02-21, 22:49, Jonathan Marek wrote:
> Use the correct name to avoid ldo7 commands being sent to ldo6's address.

Thanks for spotting and fixing it.

Reviewed-by: Vinod Koul <vkoul@kernel.org>

> Fixes: 06369bcc15a1 ("regulator: qcom-rpmh: Add support for SM8150")
> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
> ---
>  drivers/regulator/qcom-rpmh-regulator.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c
> index 05f1b4e150f4..043dc2fd39eb 100644
> --- a/drivers/regulator/qcom-rpmh-regulator.c
> +++ b/drivers/regulator/qcom-rpmh-regulator.c
> @@ -937,7 +937,7 @@ static const struct rpmh_vreg_init_data pm8009_vreg_data[] = {
>  	RPMH_VREG("ldo4",   "ldo%s4",  &pmic5_nldo,      "vdd-l4"),
>  	RPMH_VREG("ldo5",   "ldo%s5",  &pmic5_pldo,      "vdd-l5-l6"),
>  	RPMH_VREG("ldo6",   "ldo%s6",  &pmic5_pldo,      "vdd-l5-l6"),
> -	RPMH_VREG("ldo7",   "ldo%s6",  &pmic5_pldo_lv,   "vdd-l7"),
> +	RPMH_VREG("ldo7",   "ldo%s7",  &pmic5_pldo_lv,   "vdd-l7"),
>  	{},
>  };
>  
> -- 
> 2.26.1

-- 
~Vinod

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] regulator: qcom-rpmh: fix pm8009 ldo7
  2021-02-11  3:49 [PATCH] regulator: qcom-rpmh: fix pm8009 ldo7 Jonathan Marek
  2021-02-11  4:36 ` Vinod Koul
@ 2021-02-11 15:39 ` Mark Brown
  2021-03-01 19:59 ` patchwork-bot+linux-arm-msm
  2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2021-02-11 15:39 UTC (permalink / raw)
  To: linux-arm-msm, Jonathan Marek
  Cc: open list:VOLTAGE AND CURRENT REGULATOR FRAMEWORK, Andy Gross,
	Vinod Koul, Bjorn Andersson, Liam Girdwood

On Wed, 10 Feb 2021 22:49:35 -0500, Jonathan Marek wrote:
> Use the correct name to avoid ldo7 commands being sent to ldo6's address.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: qcom-rpmh: fix pm8009 ldo7
      commit: 20ccc362c3d20da734af896e075b74222589f2c0

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] regulator: qcom-rpmh: fix pm8009 ldo7
  2021-02-11  3:49 [PATCH] regulator: qcom-rpmh: fix pm8009 ldo7 Jonathan Marek
  2021-02-11  4:36 ` Vinod Koul
  2021-02-11 15:39 ` Mark Brown
@ 2021-03-01 19:59 ` patchwork-bot+linux-arm-msm
  2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+linux-arm-msm @ 2021-03-01 19:59 UTC (permalink / raw)
  To: Jonathan Marek; +Cc: linux-arm-msm

Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

On Wed, 10 Feb 2021 22:49:35 -0500 you wrote:
> Use the correct name to avoid ldo7 commands being sent to ldo6's address.
> 
> Fixes: 06369bcc15a1 ("regulator: qcom-rpmh: Add support for SM8150")
> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
> ---
>  drivers/regulator/qcom-rpmh-regulator.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - regulator: qcom-rpmh: fix pm8009 ldo7
    https://git.kernel.org/qcom/c/20ccc362c3d2

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-03-01 20:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-11  3:49 [PATCH] regulator: qcom-rpmh: fix pm8009 ldo7 Jonathan Marek
2021-02-11  4:36 ` Vinod Koul
2021-02-11 15:39 ` Mark Brown
2021-03-01 19:59 ` patchwork-bot+linux-arm-msm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).