From: Stephen Boyd <sboyd@kernel.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org,
"Ahmad Fatoum" <a.fatoum@pengutronix.de>,
"Andy Gross" <agross@kernel.org>,
"Avi Fishman" <avifishman70@gmail.com>,
"Benjamin Fair" <benjaminfair@google.com>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Boris BREZILLON" <boris.brezillon@free-electrons.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Emilio López" <emilio@elopez.com.ar>,
"Fabio Estevam" <festevam@gmail.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Jan Kotas" <jank@cadence.com>,
"Jernej Skrabec" <jernej.skrabec@siol.net>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-tegra@vger.kernel.org, "Loc Ho" <lho@apm.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Michal Simek" <michal.simek@xilinx.com>,
"Nancy Yuen" <yuenn@google.com>,
"Nuvoton Technologies" <tali.perry@nuvoton.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
openbmc@lists.ozlabs.org, "Patrick Venture" <venture@google.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Peter De Schrijver" <pdeschrijver@nvidia.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Prashant Gaikwad" <pgaikwad@nvidia.com>,
"Rajan Vaja" <rajan.vaja@xilinx.com>,
"Rajeev Kumar" <rajeev-dlh.kumar@st.com>,
"Richard Woodruff" <r-woodruff2@ti.com>,
"Russell King" <linux@armlinux.org.uk>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Shawn Guo" <shawnguo@kernel.org>,
"Shiraz Hashim" <shiraz.linux.kernel@gmail.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"Tali Perry" <tali.perry1@gmail.com>,
"Tero Kristo" <kristo@kernel.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Tomer Maimon" <tmaimon77@gmail.com>,
"Viresh Kumar" <vireshk@kernel.org>
Subject: Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock
Date: Fri, 12 Feb 2021 16:06:43 -0800 [thread overview]
Message-ID: <161317480301.1254594.16648868282165823277@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20210212223739.GE179940@dell>
Quoting Lee Jones (2021-02-12 14:37:39)
> On Fri, 12 Feb 2021, Stephen Boyd wrote:
>
> >
> > I'd like to enable it for only files under drivers/clk/ but it doesn't
> > seem to work. I'm not asking to enable it at the toplevel Makefile. I'm
> > asking to enable it for drivers/clk/ so nobody has to think about it now
> > that you've done the hard work of getting the numbers in this directory
> > down to zero or close to zero.
>
> I'm not sure which one of us is confused. Probably me, but ...
>
> Even if you could enable it per-subsystem, how would that help you?
>
> How can you ensure that contributors see any new W=1 warnings, but
> Linus doesn't? When Linus conducts his build-tests during the merge
> window, he is also going to build W=1 for drivers/clk.
The assumption is contributors would have compiled the code they're
sending, but that's obviously not always the case, so this assumption
relies on developers running make. If they do run make then the hope is
they would see the warnings now, without having to rely on them to know
about passing W=1 to make, and fix them before sending code. If
developers are ignoring build errors or warnings then we can't do
anything anyway.
>
> All that's going to achieve is put you in the firing line.
Ok. Is this prior experience?
>
> From my PoV W=1 builds should be enabled during the development phase
> (i.e. contributor, auto-builder, maintainer). By the time patches get
> make it into Mainline the review/testing stage is over and only the
> default W=0 warnings are meaningful.
>
Alright maybe I don't understand and W=1 builds are noisy for the
drivers/clk subdirectory even after applying these patches. Or it has
some false positives that won't be fixed? Or a new compiler can cause
new warnings to happen? I could see these things being a problem.
I'm trying to see if we can make lives better for everyone by exposing
the warnings by default in the drivers/clk/ directory now that there are
supposedly none left. Shouldn't we tighten the screws now that we've
cleaned them?
next prev parent reply other threads:[~2021-02-13 0:07 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 12:45 [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock Lee Jones
2021-01-26 12:45 ` [PATCH 04/21] clk: qcom: clk-regmap: Provide missing description for 'devm_clk_register_regmap()'s dev param Lee Jones
2021-01-26 13:59 ` Bjorn Andersson
2021-02-11 19:54 ` Stephen Boyd
2021-01-26 12:45 ` [PATCH 13/21] clk: qcom: gcc-ipq4019: Remove unused variable 'ret' Lee Jones
2021-01-26 14:01 ` Bjorn Andersson
2021-02-11 19:56 ` Stephen Boyd
2021-01-26 12:45 ` [PATCH 16/21] clk: qcom: mmcc-msm8974: Remove unused static const tables 'mmcc_xo_mmpll0_1_2_gpll0{map}' Lee Jones
2021-01-26 14:02 ` Bjorn Andersson
2021-02-11 19:57 ` Stephen Boyd
2021-01-26 12:45 ` [PATCH 18/21] clk: qcom: clk-rpm: Remove a bunch of superfluous code Lee Jones
2021-01-26 14:04 ` Bjorn Andersson
2021-02-11 19:57 ` Stephen Boyd
2021-02-03 8:31 ` [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock Lee Jones
2021-02-05 18:55 ` Stephen Boyd
2021-02-05 19:19 ` Lee Jones
2021-02-08 6:45 ` Tero Kristo
2021-02-11 20:47 ` Stephen Boyd
2021-02-11 21:10 ` Lee Jones
2021-02-12 3:07 ` Stephen Boyd
2021-02-12 9:20 ` Lee Jones
2021-02-12 21:02 ` Stephen Boyd
2021-02-12 21:25 ` Lee Jones
2021-02-12 21:26 ` Lee Jones
2021-02-12 22:05 ` Stephen Boyd
2021-02-12 22:37 ` Lee Jones
2021-02-13 0:06 ` Stephen Boyd [this message]
2021-02-13 16:04 ` Andrew Lunn
[not found] ` <161333644244.1254594.4498059850307971318@swboyd.mtv.corp.google.com>
2021-02-14 21:20 ` Andrew Lunn
2021-02-15 8:49 ` Lee Jones
2021-02-15 17:45 ` Jakub Kicinski
2021-02-16 8:20 ` Lee Jones
2021-02-17 18:08 ` Jakub Kicinski
2021-02-18 9:31 ` Lee Jones
2021-02-13 15:58 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161317480301.1254594.16648868282165823277@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=a.fatoum@pengutronix.de \
--cc=agross@kernel.org \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=boris.brezillon@free-electrons.com \
--cc=emilio@elopez.com.ar \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=jank@cadence.com \
--cc=jernej.skrabec@siol.net \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=kristo@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lho@apm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michal.simek@xilinx.com \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=openbmc@lists.ozlabs.org \
--cc=p.zabel@pengutronix.de \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=r-woodruff2@ti.com \
--cc=rajan.vaja@xilinx.com \
--cc=rajeev-dlh.kumar@st.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shiraz.linux.kernel@gmail.com \
--cc=soren.brinkmann@xilinx.com \
--cc=tali.perry1@gmail.com \
--cc=tali.perry@nuvoton.com \
--cc=thierry.reding@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=vireshk@kernel.org \
--cc=wens@csie.org \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).