From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A350DC433DB for ; Wed, 24 Feb 2021 07:07:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4FAED64EBA for ; Wed, 24 Feb 2021 07:07:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234335AbhBXHHT (ORCPT ); Wed, 24 Feb 2021 02:07:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234324AbhBXHHP (ORCPT ); Wed, 24 Feb 2021 02:07:15 -0500 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 777D5C06178B for ; Tue, 23 Feb 2021 23:06:35 -0800 (PST) Received: by mail-pg1-x52a.google.com with SMTP id e6so877867pgk.5 for ; Tue, 23 Feb 2021 23:06:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=7filuQzM3PPCew10cLsd+/0g628RiDn4obN6lLezpSc=; b=mZZX/EGIjnB4uQuujiuMKYg1F90fFxEsLP5wBKXKMZZ0/VRHfLvUJmWVQMsh7hn3oC POJo4IRMdSmQaNLZxD85lyneVPaoxPuwCFx+rCnxSlpsUwHxu/ZsV7FufEa7JoVDzypW d3qgNzk6bQsa0yZrbGJRTb1qRrBaQ+7DylFhY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=7filuQzM3PPCew10cLsd+/0g628RiDn4obN6lLezpSc=; b=TNLPjHWcxk20nbbHqB+Mdp363g7DqYE/qVVyvdV57gDrSNyStXUax2y28PNwiZXD3F rTXzfonPiJRUIOGTNJYPvfE2rW/XYqV3HpBxgyKr8GUpuGFXT8EKffDOEACZGMJBPV7X hlPQDRfBTpFpYlK1aH4p6yr6TmF8ZLlCf/LfxTNN8GwI2U9ODre+L8zcInh+D/Of3fdc zHE4gK3ieg+Zgm0C+oSSg1fznEpdZMD2DfLhE2l7zBi/1numP8x6ikos2iEoq5ZDrDoS rcaThBiGgTnnIqOroQAOZmv5Q/iVZZTGYJ5MU7TpJXbTbGu0MUzrZAnRHU92OCKzRPRi 6VMA== X-Gm-Message-State: AOAM532W8YxvSWuLf+UCmSYqxkchMZx06xSo3HaJx4KhlUOV6/BA7kyV 7S5s0KhhVLPFjtD/3oJYGXLvKA== X-Google-Smtp-Source: ABdhPJya7bcsUCvP9njl0gp25N2HQyAv9CG7JucH2KgHeK39shLD0REzuuejwM4p4tpQJy/Aw3wlJA== X-Received: by 2002:a63:134c:: with SMTP id 12mr27479803pgt.262.1614150393980; Tue, 23 Feb 2021 23:06:33 -0800 (PST) Received: from chromium.org ([2620:15c:202:201:933:e73c:97ad:add3]) by smtp.gmail.com with ESMTPSA id z11sm1076222pgk.65.2021.02.23.23.06.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Feb 2021 23:06:33 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <9ec10130df230a0ff078d9eec47e94b2@codeaurora.org> References: <20210108150545.2018-1-rojay@codeaurora.org> <20210108150545.2018-2-rojay@codeaurora.org> <161052087940.3661239.14609415796697267628@swboyd.mtv.corp.google.com> <9ec10130df230a0ff078d9eec47e94b2@codeaurora.org> Subject: Re: [PATCH V8 1/1] i2c: i2c-qcom-geni: Add shutdown callback for i2c From: Stephen Boyd Cc: wsa@kernel.org, dianders@chromium.org, saiprakash.ranjan@codeaurora.org, gregkh@linuxfoundation.org, mka@chromium.org, akashast@codeaurora.org, msavaliy@qti.qualcomm.com, skakit@codeaurora.org, rnayak@codeaurora.org, agross@kernel.org, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, sumit.semwal@linaro.org, linux-media@vger.kernel.org To: rojay@codeaurora.org Date: Tue, 23 Feb 2021 23:06:31 -0800 Message-ID: <161415039142.1254594.3043511127113195221@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting rojay@codeaurora.org (2021-02-18 06:15:17) > Hi Stephen, >=20 > On 2021-01-13 12:24, Stephen Boyd wrote: > > Quoting Roja Rani Yarubandi (2021-01-08 07:05:45) > >> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c=20 > >> b/drivers/i2c/busses/i2c-qcom-geni.c > >> index 214b4c913a13..c3f584795911 100644 > >> --- a/drivers/i2c/busses/i2c-qcom-geni.c > >> +++ b/drivers/i2c/busses/i2c-qcom-geni.c > >> @@ -375,6 +375,32 @@ static void geni_i2c_tx_msg_cleanup(struct=20 > >> geni_i2c_dev *gi2c, > >> } > >> } > >>=20 > >> +static void geni_i2c_stop_xfer(struct geni_i2c_dev *gi2c) > >> +{ > >> + int ret; > >> + u32 geni_status; > >> + struct i2c_msg *cur; > >> + > >> + /* Resume device, as runtime suspend can happen anytime during= =20 > >> transfer */ > >> + ret =3D pm_runtime_get_sync(gi2c->se.dev); > >> + if (ret < 0) { > >> + dev_err(gi2c->se.dev, "Failed to resume device: %d\n",= =20 > >> ret); > >> + return; > >> + } > >> + > >> + geni_status =3D readl_relaxed(gi2c->se.base + SE_GENI_STATUS); > >> + if (geni_status & M_GENI_CMD_ACTIVE) { > >> + cur =3D gi2c->cur; > >=20 > > Why don't we need to hold the spinlock gi2c::lock here? > >=20 >=20 > I am not seeing any race here. May I know which race are you suspecting=20 > here? Sorry there are long delays between posting and replies to my review comments. It takes me some time to remember what we're talking about because this patch has dragged on for many months. So my understanding is that gi2c::lock protects the 'cur' pointer. I imagine this scenario might go bad CPU0 CPU1 ---- ---- geni_i2c_stop_xfer() =20 ... geni_i2c_rx_one_msg() gi2c->cur =3D cur1; cur =3D gi2c->cur; ... geni_i2c_tx_one_msg() gi2c->cur =3D cur2; geni_i2c_abort_xfer() if (cur->flags & I2C_M_RD) It's almost like we should combine the geni_i2c_abort_xfer() logic with the rx/tx message cleanup functions so that it's all done under one lock. Unfortunately it's complicated by the fact that there are various completion waiting timeouts involved. Fun! But even after all that, I don't see how the geni_i2c_stop_xfer() puts a stop to future calls to geni_i2c_rx_one_msg() or geni_i2c_tx_one_msg(). The hardware isn't disabled from what I can tell. The irq isn't disabled, the clks aren't turned off, etc. What is to stop an i2c device from trying to use the bus after this shutdown function is called? If anything, this function looks like a "flush", where we flush out any pending transfer. Where's the "plug" operation that prevents any future operations from following this call? BTW, I see this is merged upstream. That's great, but it seems broken. Please fix it or revert it out. >=20 > >> + geni_i2c_abort_xfer(gi2c); > >> + if (cur->flags & I2C_M_RD) > >> + geni_i2c_rx_msg_cleanup(gi2c, cur); > >> + else > >> + geni_i2c_tx_msg_cleanup(gi2c, cur); > >> + } > >> + > >> + pm_runtime_put_sync_suspend(gi2c->se.dev); > >> +} > >> + > >> static int geni_i2c_rx_one_msg(struct geni_i2c_dev *gi2c, struct=20 > >> i2c_msg *msg, > >> u32 m_param) > >> {