From: Stephen Boyd <sboyd@kernel.org>
To: Andy Gross <agross@kernel.org>,
Bartosz Dudziak <bartosz.dudziak@snejp.pl>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Bartosz Dudziak <bartosz.dudziak@snejp.pl>
Subject: Re: [PATCH 2/5] clk: qcom: gcc: Add support for Global Clock controller found on MSM8226
Date: Fri, 26 Mar 2021 11:23:58 -0700 [thread overview]
Message-ID: <161678303809.3012082.14127191260312393003@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20210326145816.9758-3-bartosz.dudziak@snejp.pl>
Quoting Bartosz Dudziak (2021-03-26 07:58:13)
> Modify existing MSM8974 driver to support MSM8226 SoC. Override frequencies
> which are different in this older chip. Register all the clocks to the
> framework for the clients to be able to request for them.
Alphabet sort includes? Preferably do that in a different patch.
>
> Signed-off-by: Bartosz Dudziak <bartosz.dudziak@snejp.pl>
> ---
> drivers/clk/qcom/gcc-msm8974.c | 185 ++++++++++++++++++++++++++++++---
> 1 file changed, 171 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/clk/qcom/gcc-msm8974.c b/drivers/clk/qcom/gcc-msm8974.c
> index 740d3c44c0..06cd669e10 100644
> --- a/drivers/clk/qcom/gcc-msm8974.c
> +++ b/drivers/clk/qcom/gcc-msm8974.c
> @@ -3,16 +3,13 @@
> * Copyright (c) 2013, The Linux Foundation. All rights reserved.
> */
>
> -#include <linux/kernel.h>
> -#include <linux/bitops.h>
> +#include <linux/clk-provider.h>
> #include <linux/err.h>
> -#include <linux/platform_device.h>
> +#include <linux/kernel.h>
> #include <linux/module.h>
> -#include <linux/of.h>
> #include <linux/of_device.h>
> -#include <linux/clk-provider.h>
> +#include <linux/of.h>
> #include <linux/regmap.h>
> -#include <linux/reset-controller.h>
>
> #include <dt-bindings/clock/qcom,gcc-msm8974.h>
> #include <dt-bindings/reset/qcom,gcc-msm8974.h>
> @@ -2727,7 +2880,11 @@ static int gcc_msm8974_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - return qcom_cc_probe(pdev, &gcc_msm8974_desc);
> + regmap = qcom_cc_map(pdev, id->data);
> + if (IS_ERR(regmap))
> + return PTR_ERR(regmap);
> +
> + return qcom_cc_really_probe(pdev, id->data, regmap);
Is this doing anything? I think qcom_cc_probe(pdev, id->data) should
work?
next prev parent reply other threads:[~2021-03-26 18:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 14:58 [PATCH 0/5] Samsung Galaxy S III Neo Initial DTS Bartosz Dudziak
2021-03-26 14:58 ` [PATCH 1/5] dt-bindings: clock: qcom: Add MSM8226 GCC clock bindings Bartosz Dudziak
2021-03-27 18:40 ` Rob Herring
2021-03-26 14:58 ` [PATCH 2/5] clk: qcom: gcc: Add support for Global Clock controller found on MSM8226 Bartosz Dudziak
2021-03-26 18:23 ` Stephen Boyd [this message]
2021-03-26 14:58 ` [PATCH 3/5] arm: dts: qcom: Add support for MSM8226 SoC Bartosz Dudziak
2021-03-26 18:21 ` Stephen Boyd
2021-03-30 3:41 ` Bjorn Andersson
2021-03-26 14:58 ` [PATCH 4/5] dt-bindings: arm: qcom: Document MSM8226 SoC binding Bartosz Dudziak
2021-03-27 18:40 ` Rob Herring
2021-03-26 14:58 ` [PATCH 5/5] arm: dts: qcom: Add initial DTS file for Samsung Galaxy S III Neo phone Bartosz Dudziak
2021-03-29 0:50 ` kernel test robot
2021-04-18 13:00 ` [PATCH 0/5] Samsung Galaxy S III Neo Initial DTS Bartosz Dudziak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161678303809.3012082.14127191260312393003@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=bartosz.dudziak@snejp.pl \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).