From: Stephen Boyd <swboyd@chromium.org>
To: Maxime Ripard <maxime@cerno.tech>
Cc: dri-devel@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@intel.com>,
David Airlie <airlied@linux.ie>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Clark <robdclark@gmail.com>,
linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org
Subject: Re: [PATCH v3 10/11] drm: Use state helper instead of the plane state pointer
Date: Tue, 30 Mar 2021 11:56:15 -0700 [thread overview]
Message-ID: <161713057558.2260335.5422873422021430866@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20210330153527.gw33t4o2b35wwzbg@gilmour>
Quoting Maxime Ripard (2021-03-30 08:35:27)
> Hi Stephen,
>
> On Mon, Mar 29, 2021 at 06:52:01PM -0700, Stephen Boyd wrote:
> > Trimming Cc list way down, sorry if that's too much.
> >
> > Quoting Maxime Ripard (2021-02-19 04:00:30)
> > > Many drivers reference the plane->state pointer in order to get the
> > > current plane state in their atomic_update or atomic_disable hooks,
> > > which would be the new plane state in the global atomic state since
> > > _swap_state happened when those hooks are run.
> >
> > Does this mean drm_atomic_helper_swap_state()?
>
> Yep. Previous to that call in drm_atomic_helper_commit, plane->state is
> the state currently programmed in the hardware, so the old state (that's
> the case you have with atomic_check for example)
>
> Once drm_atomic_helper_swap_state has run, plane->state is now the state
> that needs to be programmed into the hardware, so the new state.
Ok, and I suppose that is called by drm_atomic_helper_commit()? So
presumably a modeset is causing this? I get the NULL pointer around the
time we switch from the splash screen to the login screen. I think
there's a modeset during that transition.
next prev parent reply other threads:[~2021-03-30 18:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 12:00 [PATCH v3 01/11] drm/atomic: Pass the full state to planes async atomic check and update Maxime Ripard
2021-02-19 12:00 ` [PATCH v3 02/11] drm: Rename plane atomic_check state names Maxime Ripard
2021-02-19 14:49 ` Thomas Zimmermann
2021-02-19 15:12 ` Maxime Ripard
2021-02-22 9:01 ` Thomas Zimmermann
2021-02-19 12:00 ` [PATCH v3 04/11] drm/atomic: Pass the full state to planes atomic_check Maxime Ripard
2021-02-22 9:00 ` Thomas Zimmermann
2021-02-19 12:00 ` [PATCH v3 05/11] drm: Use the state pointer directly in " Maxime Ripard
2021-02-22 9:05 ` Thomas Zimmermann
2021-02-19 12:00 ` [PATCH v3 06/11] drm: Use state helper instead of plane state pointer in atomic_check Maxime Ripard
2021-02-22 9:12 ` Thomas Zimmermann
2021-02-23 14:41 ` Maxime Ripard
2021-02-19 12:00 ` [PATCH v3 08/11] drm: Rename plane->state variables in atomic update and disable Maxime Ripard
2021-02-19 12:00 ` [PATCH v3 09/11] drm/atomic: Pass the full state to planes atomic disable and update Maxime Ripard
2021-02-19 12:00 ` [PATCH v3 10/11] drm: Use state helper instead of the plane state pointer Maxime Ripard
2021-03-30 1:52 ` Stephen Boyd
2021-03-30 15:35 ` Maxime Ripard
2021-03-30 18:56 ` Stephen Boyd [this message]
2021-04-08 13:20 ` Maxime Ripard
2021-04-30 16:44 ` Rob Clark
2021-05-04 7:40 ` Daniel Vetter
2021-02-24 11:33 ` [PATCH v3 01/11] drm/atomic: Pass the full state to planes async atomic check and update Thomas Zimmermann
2021-02-25 7:08 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161713057558.2260335.5422873422021430866@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime@cerno.tech \
--cc=robdclark@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).