linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bhaumik Bhatt <bbhatt@codeaurora.org>
To: manivannan.sadhasivam@linaro.org
Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org,
	jhugo@codeaurora.org, linux-kernel@vger.kernel.org,
	carl.yin@quectel.com, naveen.kumar@quectel.com,
	loic.poulain@linaro.org, Bhaumik Bhatt <bbhatt@codeaurora.org>
Subject: [PATCH v8 6/9] bus: mhi: core: Clear configuration from channel context during reset
Date: Thu,  1 Apr 2021 14:16:15 -0700	[thread overview]
Message-ID: <1617311778-1254-7-git-send-email-bbhatt@codeaurora.org> (raw)
In-Reply-To: <1617311778-1254-1-git-send-email-bbhatt@codeaurora.org>

When clearing up the channel context after client drivers are
done using channels, the configuration is currently not being
reset entirely. Ensure this is done to appropriately handle
issues where clients unaware of the context state end up calling
functions which expect a context.

Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 drivers/bus/mhi/core/init.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
index 9c2ed92..871a412 100644
--- a/drivers/bus/mhi/core/init.c
+++ b/drivers/bus/mhi/core/init.c
@@ -558,6 +558,7 @@ void mhi_deinit_chan_ctxt(struct mhi_controller *mhi_cntrl,
 	struct mhi_ring *buf_ring;
 	struct mhi_ring *tre_ring;
 	struct mhi_chan_ctxt *chan_ctxt;
+	u32 tmp;
 
 	buf_ring = &mhi_chan->buf_ring;
 	tre_ring = &mhi_chan->tre_ring;
@@ -571,7 +572,19 @@ void mhi_deinit_chan_ctxt(struct mhi_controller *mhi_cntrl,
 	vfree(buf_ring->base);
 
 	buf_ring->base = tre_ring->base = NULL;
+	tre_ring->ctxt_wp = NULL;
 	chan_ctxt->rbase = 0;
+	chan_ctxt->rlen = 0;
+	chan_ctxt->rp = 0;
+	chan_ctxt->wp = 0;
+
+	tmp = chan_ctxt->chcfg;
+	tmp &= ~CHAN_CTX_CHSTATE_MASK;
+	tmp |= (MHI_CH_STATE_DISABLED << CHAN_CTX_CHSTATE_SHIFT);
+	chan_ctxt->chcfg = tmp;
+
+	/* Update to all cores */
+	smp_wmb();
 }
 
 int mhi_init_chan_ctxt(struct mhi_controller *mhi_cntrl,
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


  parent reply	other threads:[~2021-04-01 21:16 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01 21:16 Bhaumik Bhatt
2021-04-01 21:16 ` [PATCH v8 1/9] bus: mhi: core: Allow sending the STOP channel command Bhaumik Bhatt
2021-05-04 17:40   ` Jeffrey Hugo
2021-05-26 19:03   ` patchwork-bot+linux-arm-msm
2021-04-01 21:16 ` [PATCH v8 2/9] bus: mhi: core: Clear context for stopped channels from remove() Bhaumik Bhatt
2021-05-04 17:41   ` Jeffrey Hugo
2021-04-01 21:16 ` [PATCH v8 3/9] bus: mhi: core: Improvements to the channel handling state machine Bhaumik Bhatt
2021-04-07  6:26   ` Manivannan Sadhasivam
2021-05-04 17:43   ` Jeffrey Hugo
2021-04-01 21:16 ` [PATCH v8 4/9] bus: mhi: core: Update debug messages to use client device Bhaumik Bhatt
2021-04-07  6:27   ` Manivannan Sadhasivam
2021-05-04 17:45   ` Jeffrey Hugo
2021-04-01 21:16 ` [PATCH v8 5/9] bus: mhi: core: Hold device wake for channel update commands Bhaumik Bhatt
2021-04-07  6:31   ` Manivannan Sadhasivam
2021-05-04 17:46   ` Jeffrey Hugo
2021-04-01 21:16 ` Bhaumik Bhatt [this message]
2021-05-04 17:48   ` [PATCH v8 6/9] bus: mhi: core: Clear configuration from channel context during reset Jeffrey Hugo
2021-04-01 21:16 ` [PATCH v8 7/9] bus: mhi: core: Check channel execution environment before issuing reset Bhaumik Bhatt
2021-05-04 17:49   ` Jeffrey Hugo
2021-04-01 21:16 ` [PATCH v8 8/9] bus: mhi: core: Remove __ prefix for MHI channel unprepare function Bhaumik Bhatt
2021-05-04 17:50   ` Jeffrey Hugo
2021-04-01 21:16 ` [PATCH v8 9/9] bus: mhi: Improve documentation on channel transfer setup APIs Bhaumik Bhatt
2021-05-04 17:51   ` Jeffrey Hugo
2021-04-07  6:56 ` your mail Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1617311778-1254-7-git-send-email-bbhatt@codeaurora.org \
    --to=bbhatt@codeaurora.org \
    --cc=carl.yin@quectel.com \
    --cc=hemantk@codeaurora.org \
    --cc=jhugo@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=naveen.kumar@quectel.com \
    --subject='Re: [PATCH v8 6/9] bus: mhi: core: Clear configuration from channel context during reset' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).