From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 619EDC433ED for ; Sat, 10 Apr 2021 02:13:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2EE42611AF for ; Sat, 10 Apr 2021 02:13:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234171AbhDJCOJ (ORCPT ); Fri, 9 Apr 2021 22:14:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233957AbhDJCOJ (ORCPT ); Fri, 9 Apr 2021 22:14:09 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D6E6C061763 for ; Fri, 9 Apr 2021 19:13:56 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id q6-20020a17090a4306b02900c42a012202so4068055pjg.5 for ; Fri, 09 Apr 2021 19:13:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=nLePSplx7PtSkXHGdXyCusnm0ImMRD9rerpY+TAlPHg=; b=cXw10tBrh9lVLSS0FkJG7oTiJtaMODJjfgdmqz4mTEi+hVS0Wr48giTPDmIyZzQf6r 2mKJvQ/xUxJMdPj5PNzMlmNkpDJfTaCxaYMqHxs+kb7y8ZfL8Tp+0zVUq3v7OVyaDqFs tdDAHKHxr427clCOZZi7nY1dc1dsdxkYQcGoo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=nLePSplx7PtSkXHGdXyCusnm0ImMRD9rerpY+TAlPHg=; b=TutiX1Ozc0B7YQiYgdm4b4zFJ88PNuujDhUnUQ4EBTNHxLY87RRAFnC4clkuHxtHj2 i7/5NQNUJfB5YYC5waWC2l7Z3m51W/7HbXoyOIYv1P2epZMnnuKPG3NW/uhqnNmjHQQ7 B6sWL0RD/GwtjTC0twoo1lmd9Omle0JZ6bRuIyDjTls3MwAccdJetrSJgj2okdjXGCs9 AUeLouxVtukf0jzKot62jXosP392+neCgksTWrivq4YIfEnfqFqA5RCSSzfnKq/LBIes LFDrg1XMCNgxRIXFoNCLBPIT8HHvOI7mWWpbK9Cd2syCyGwLM81dn1yIDg6fiTd/AwMb u7cg== X-Gm-Message-State: AOAM530LljRoC0nouAMXJViSSAs6pRjkTt3wO7CCNTFxhRGwJ7ipoT5J HsTmHS0Lor9aGoqIlYVpN/au3w== X-Google-Smtp-Source: ABdhPJyDcS64ZZFzixjsjMMnAtyV704sq0UdPuwlwsXio8lAwsnAuX2nMSAYMbgnNY74A6RJcHXizw== X-Received: by 2002:a17:90a:55ca:: with SMTP id o10mr16069191pjm.173.1618020835728; Fri, 09 Apr 2021 19:13:55 -0700 (PDT) Received: from chromium.org ([2620:15c:202:201:5141:7881:7013:743b]) by smtp.gmail.com with ESMTPSA id q15sm3795524pje.28.2021.04.09.19.13.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Apr 2021 19:13:55 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1618020280-5470-2-git-send-email-tdas@codeaurora.org> References: <1618020280-5470-1-git-send-email-tdas@codeaurora.org> <1618020280-5470-2-git-send-email-tdas@codeaurora.org> Subject: Re: [PATCH v1 1/2] arm64: dts: qcom: sc7280: Add cpufreq hw node From: Stephen Boyd Cc: Douglas Anderson , Andy Gross , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Taniya Das To: Bjorn Andersson , Rob Herring , Taniya Das Date: Fri, 09 Apr 2021 19:13:53 -0700 Message-ID: <161802083374.3764895.12006553235097369856@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Taniya Das (2021-04-09 19:04:39) > @@ -1116,6 +1124,17 @@ > #clock-cells =3D <1>; > }; > }; > + > + cpufreq_hw: cpufreq@18591000 { > + compatible =3D "qcom,cpufreq-epss"; > + reg =3D <0 0x18591000 0 0x1000>, > + <0 0x18592000 0 0x1000>, > + <0 0x18593000 0 0x1000>; > + reg-names =3D "freq-domain0", "freq-domain1", "fr= eq-domain2"; The reg-names provides practically no value. Can you drop it? > + clocks =3D <&rpmhcc RPMH_CXO_CLK>, <&gcc GCC_GPLL= 0>; > + clock-names =3D "xo", "alternate"; > + #freq-domain-cells =3D <1>; > + }; > }; >