archive mirror
 help / color / mirror / Atom feed
From: Sandeep Maheswaram <>
To: Greg Kroah-Hartman <>,
	Felipe Balbi <>,
	Stephen Boyd <>,
	Doug Anderson <>,
	Matthias Kaehlcke <>
	Manu Gautam <>,
	Sandeep Maheswaram <>
Subject: [PATCH v2] usb: dwc3: core: Add shutdown callback for dwc3
Date: Wed, 14 Apr 2021 11:33:29 +0530	[thread overview]
Message-ID: <> (raw)

This patch adds a shutdown callback to USB DWC core driver to ensure that
it is properly shutdown in reboot/shutdown path. This is required
where SMMU address translation is enabled like on SC7180
SoC and few others. If the hardware is still accessing memory after
SMMU translation is disabled as part of SMMU shutdown callback in
system reboot or shutdown path, then IOVAs(I/O virtual address)
which it was using will go on the bus as the physical addresses which
might result in unknown crashes (NoC/interconnect errors).

Signed-off-by: Sandeep Maheswaram <>
Changes in v2:
        - As per Stephen's comment, calling dwc3_remove in dwc3_shutdown.

 drivers/usb/dwc3/core.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 05e2e54c..2022d90 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -1658,6 +1658,11 @@ static int dwc3_remove(struct platform_device *pdev)
 	return 0;
+static void dwc3_shutdown(struct platform_device *pdev)
+	dwc3_remove(pdev);
 #ifdef CONFIG_PM
 static int dwc3_core_init_for_resume(struct dwc3 *dwc)
@@ -1975,6 +1980,7 @@ MODULE_DEVICE_TABLE(acpi, dwc3_acpi_match);
 static struct platform_driver dwc3_driver = {
 	.probe		= dwc3_probe,
 	.remove		= dwc3_remove,
+	.shutdown   = dwc3_shutdown,
 	.driver		= {
 		.name	= "dwc3",
 		.of_match_table	= of_match_ptr(of_dwc3_match),
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

             reply	other threads:[~2021-04-14  6:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-14  6:03 Sandeep Maheswaram [this message]
2021-04-14  8:12 ` Felipe Balbi
2021-04-14 16:02 ` Stephen Boyd
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2] usb: dwc3: core: Add shutdown callback for dwc3' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).