Linux-ARM-MSM Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2] arm64: dts: qcom: Update iommu property for simultaneous playback
@ 2021-04-06 16:33 Srinivasa Rao Mandadapu
  2021-04-09 17:01 ` Stephen Boyd
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Srinivasa Rao Mandadapu @ 2021-04-06 16:33 UTC (permalink / raw)
  To: agross, bjorn.andersson, robh+dt, linux-arm-msm, devicetree,
	linux-kernel, rohitkr, srinivas.kandagatla, dianders, swboyd,
	judyhsiao
  Cc: V Sujith Kumar Reddy, Srinivasa Rao Mandadapu

From: V Sujith Kumar Reddy <vsujithk@codeaurora.org>

Update iommu property in lpass cpu node for supporting
simultaneous playback on headset and speaker.

Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
---
Changes since v1:
   -- Commit messge header change

 arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index a6da78d31fdd..6228ba2d8513 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -3566,7 +3566,8 @@ lpass_cpu: lpass@62f00000 {
 			reg = <0 0x62f00000 0 0x29000>;
 			reg-names = "lpass-lpaif";
 
-			iommus = <&apps_smmu 0x1020 0>;
+			iommus = <&apps_smmu 0x1020 0>,
+				<&apps_smmu 0x1021 0>;
 
 			power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>;
 
-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] arm64: dts: qcom: Update iommu property for simultaneous playback
  2021-04-06 16:33 [PATCH v2] arm64: dts: qcom: Update iommu property for simultaneous playback Srinivasa Rao Mandadapu
@ 2021-04-09 17:01 ` Stephen Boyd
  2021-04-10  5:17   ` Srinivasa Rao Mandadapu
  2021-04-12 19:07 ` Stephen Boyd
  2021-04-19 14:50 ` patchwork-bot+linux-arm-msm
  2 siblings, 1 reply; 6+ messages in thread
From: Stephen Boyd @ 2021-04-09 17:01 UTC (permalink / raw)
  To: Srinivasa Rao Mandadapu, agross, bjorn.andersson, devicetree,
	dianders, judyhsiao, linux-arm-msm, linux-kernel, robh+dt,
	rohitkr, srinivas.kandagatla
  Cc: V Sujith Kumar Reddy, Srinivasa Rao Mandadapu

Quoting Srinivasa Rao Mandadapu (2021-04-06 09:33:30)
> From: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
> 
> Update iommu property in lpass cpu node for supporting
> simultaneous playback on headset and speaker.
> 
> Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
> ---
> Changes since v1:
>    -- Commit messge header change
> 
>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index a6da78d31fdd..6228ba2d8513 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -3566,7 +3566,8 @@ lpass_cpu: lpass@62f00000 {
>                         reg = <0 0x62f00000 0 0x29000>;
>                         reg-names = "lpass-lpaif";
>  
> -                       iommus = <&apps_smmu 0x1020 0>;
> +                       iommus = <&apps_smmu 0x1020 0>,
> +                               <&apps_smmu 0x1021 0>;

The stream ID 0x1032 was also dropped in this version but there's no
mention of that in the changelog. Why?

>  
>                         power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>;
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] arm64: dts: qcom: Update iommu property for simultaneous playback
  2021-04-09 17:01 ` Stephen Boyd
@ 2021-04-10  5:17   ` Srinivasa Rao Mandadapu
  2021-04-12 19:07     ` Stephen Boyd
  0 siblings, 1 reply; 6+ messages in thread
From: Srinivasa Rao Mandadapu @ 2021-04-10  5:17 UTC (permalink / raw)
  To: Stephen Boyd, agross, bjorn.andersson, devicetree, dianders,
	judyhsiao, linux-arm-msm, linux-kernel, robh+dt, rohitkr,
	srinivas.kandagatla
  Cc: V Sujith Kumar Reddy

Hi Stephen.

Thanks for your time!!!


On 4/9/2021 10:31 PM, Stephen Boyd wrote:
> Quoting Srinivasa Rao Mandadapu (2021-04-06 09:33:30)
>> From: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
>>
>> Update iommu property in lpass cpu node for supporting
>> simultaneous playback on headset and speaker.
>>
>> Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
>> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
>> ---
>> Changes since v1:
>>     -- Commit messge header change
>>
>>   arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> index a6da78d31fdd..6228ba2d8513 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> @@ -3566,7 +3566,8 @@ lpass_cpu: lpass@62f00000 {
>>                          reg = <0 0x62f00000 0 0x29000>;
>>                          reg-names = "lpass-lpaif";
>>   
>> -                       iommus = <&apps_smmu 0x1020 0>;
>> +                       iommus = <&apps_smmu 0x1020 0>,
>> +                               <&apps_smmu 0x1021 0>;
> The stream ID 0x1032 was also dropped in this version but there's no
> mention of that in the changelog. Why?
That is ID is for HDMI Stream, so as part of DP patches that will be added.
>
>>   
>>                          power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>;
>>
-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] arm64: dts: qcom: Update iommu property for simultaneous playback
  2021-04-06 16:33 [PATCH v2] arm64: dts: qcom: Update iommu property for simultaneous playback Srinivasa Rao Mandadapu
  2021-04-09 17:01 ` Stephen Boyd
@ 2021-04-12 19:07 ` Stephen Boyd
  2021-04-19 14:50 ` patchwork-bot+linux-arm-msm
  2 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2021-04-12 19:07 UTC (permalink / raw)
  To: Srinivasa Rao Mandadapu, agross, bjorn.andersson, devicetree,
	dianders, judyhsiao, linux-arm-msm, linux-kernel, robh+dt,
	rohitkr, srinivas.kandagatla
  Cc: V Sujith Kumar Reddy, Srinivasa Rao Mandadapu

Quoting Srinivasa Rao Mandadapu (2021-04-06 09:33:30)
> From: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
> 
> Update iommu property in lpass cpu node for supporting
> simultaneous playback on headset and speaker.
> 
> Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] arm64: dts: qcom: Update iommu property for simultaneous playback
  2021-04-10  5:17   ` Srinivasa Rao Mandadapu
@ 2021-04-12 19:07     ` Stephen Boyd
  0 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2021-04-12 19:07 UTC (permalink / raw)
  To: Srinivasa Rao Mandadapu, agross, bjorn.andersson, devicetree,
	dianders, judyhsiao, linux-arm-msm, linux-kernel, robh+dt,
	rohitkr, srinivas.kandagatla
  Cc: V Sujith Kumar Reddy

Quoting Srinivasa Rao Mandadapu (2021-04-09 22:17:07)
> Hi Stephen.
> 
> Thanks for your time!!!
> 
> 
> On 4/9/2021 10:31 PM, Stephen Boyd wrote:
> > Quoting Srinivasa Rao Mandadapu (2021-04-06 09:33:30)
> >> From: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
> >>
> >> Update iommu property in lpass cpu node for supporting
> >> simultaneous playback on headset and speaker.
> >>
> >> Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
> >> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
> >> ---
> >> Changes since v1:
> >>     -- Commit messge header change
> >>
> >>   arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 ++-
> >>   1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> >> index a6da78d31fdd..6228ba2d8513 100644
> >> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> >> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> >> @@ -3566,7 +3566,8 @@ lpass_cpu: lpass@62f00000 {
> >>                          reg = <0 0x62f00000 0 0x29000>;
> >>                          reg-names = "lpass-lpaif";
> >>   
> >> -                       iommus = <&apps_smmu 0x1020 0>;
> >> +                       iommus = <&apps_smmu 0x1020 0>,
> >> +                               <&apps_smmu 0x1021 0>;
> > The stream ID 0x1032 was also dropped in this version but there's no
> > mention of that in the changelog. Why?
> That is ID is for HDMI Stream, so as part of DP patches that will be added.

Ok, got it.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] arm64: dts: qcom: Update iommu property for simultaneous playback
  2021-04-06 16:33 [PATCH v2] arm64: dts: qcom: Update iommu property for simultaneous playback Srinivasa Rao Mandadapu
  2021-04-09 17:01 ` Stephen Boyd
  2021-04-12 19:07 ` Stephen Boyd
@ 2021-04-19 14:50 ` patchwork-bot+linux-arm-msm
  2 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+linux-arm-msm @ 2021-04-19 14:50 UTC (permalink / raw)
  To: Srinivasa Rao Mandadapu; +Cc: linux-arm-msm

Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

On Tue,  6 Apr 2021 22:03:30 +0530 you wrote:
> From: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
> 
> Update iommu property in lpass cpu node for supporting
> simultaneous playback on headset and speaker.
> 
> Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
> 
> [...]

Here is the summary with links:
  - [v2] arm64: dts: qcom: Update iommu property for simultaneous playback
    https://git.kernel.org/qcom/c/367a8230fc88

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-06 16:33 [PATCH v2] arm64: dts: qcom: Update iommu property for simultaneous playback Srinivasa Rao Mandadapu
2021-04-09 17:01 ` Stephen Boyd
2021-04-10  5:17   ` Srinivasa Rao Mandadapu
2021-04-12 19:07     ` Stephen Boyd
2021-04-12 19:07 ` Stephen Boyd
2021-04-19 14:50 ` patchwork-bot+linux-arm-msm

Linux-ARM-MSM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \
		linux-arm-msm@vger.kernel.org
	public-inbox-index linux-arm-msm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git