From: Bhaumik Bhatt <bbhatt@codeaurora.org>
To: manivannan.sadhasivam@linaro.org
Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org,
jhugo@codeaurora.org, linux-kernel@vger.kernel.org,
loic.poulain@linaro.org, linux-wireless@vger.kernel.org,
kvalo@codeaurora.org, ath11k@lists.infradead.org,
Bhaumik Bhatt <bbhatt@codeaurora.org>
Subject: [PATCH v2 2/6] bus: mhi: core: Set BHI and BHIe pointers to NULL in clean-up
Date: Tue, 4 May 2021 16:37:54 -0700 [thread overview]
Message-ID: <1620171478-35679-3-git-send-email-bbhatt@codeaurora.org> (raw)
In-Reply-To: <1620171478-35679-1-git-send-email-bbhatt@codeaurora.org>
Set the BHI and BHIe pointers to NULL as part of clean-up. This
makes sure that stale pointers are not accessed after powering
MHI down.
Suggested-by: Hemant Kumar <hemantk@codeaurora.org>
Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
---
drivers/bus/mhi/core/init.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
index 11c7a3d..1cc2f22 100644
--- a/drivers/bus/mhi/core/init.c
+++ b/drivers/bus/mhi/core/init.c
@@ -1132,6 +1132,9 @@ void mhi_unprepare_after_power_down(struct mhi_controller *mhi_cntrl)
mhi_cntrl->rddm_image = NULL;
}
+ mhi_cntrl->bhi = NULL;
+ mhi_cntrl->bhie = NULL;
+
mhi_deinit_dev_ctxt(mhi_cntrl);
}
EXPORT_SYMBOL_GPL(mhi_unprepare_after_power_down);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2021-05-04 23:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 23:37 [PATCH v2 0/6] BHI/BHIe improvements for MHI power purposes Bhaumik Bhatt
2021-05-04 23:37 ` [PATCH v2 1/6] bus: mhi: core: Set BHI/BHIe offsets on power up preparation Bhaumik Bhatt
2021-05-04 23:37 ` Bhaumik Bhatt [this message]
2021-05-04 23:37 ` [PATCH v2 3/6] bus: mhi: Add MMIO region length to controller structure Bhaumik Bhatt
2021-05-05 14:37 ` Jeffrey Hugo
2021-05-04 23:37 ` [PATCH v2 4/6] ath11k: set register access length for MHI driver Bhaumik Bhatt
2021-05-04 23:37 ` [PATCH v2 5/6] bus: mhi: pci_generic: Set " Bhaumik Bhatt
2021-05-04 23:37 ` [PATCH v2 6/6] bus: mhi: core: Add range checks for BHI and BHIe Bhaumik Bhatt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1620171478-35679-3-git-send-email-bbhatt@codeaurora.org \
--to=bbhatt@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=hemantk@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
--subject='Re: [PATCH v2 2/6] bus: mhi: core: Set BHI and BHIe pointers to NULL in clean-up' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).