linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] phy: qcom-qmp: remove redundant error of clock bulk
@ 2021-05-17  5:37 Chunfeng Yun
  2021-05-31  8:20 ` Vinod Koul
  0 siblings, 1 reply; 2+ messages in thread
From: Chunfeng Yun @ 2021-05-17  5:37 UTC (permalink / raw)
  To: Kishon Vijay Abraham I, Vinod Koul
  Cc: Andy Gross, Bjorn Andersson, Matthias Brugger, linux-arm-msm,
	linux-phy, linux-kernel, linux-arm-kernel, linux-mediatek,
	Chunfeng Yun

There is error log in clk_bulk_prepare/enable()

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v2: add reviewed-by Bjorn
---
 drivers/phy/qualcomm/phy-qcom-qmp.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
index 7877f70cf86f..882b8ecae235 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
@@ -3993,10 +3993,8 @@ static int qcom_qmp_phy_com_init(struct qmp_phy *qphy)
 	}
 
 	ret = clk_bulk_prepare_enable(cfg->num_clks, qmp->clks);
-	if (ret) {
-		dev_err(qmp->dev, "failed to enable clks, err=%d\n", ret);
+	if (ret)
 		goto err_rst;
-	}
 
 	if (cfg->has_phy_dp_com_ctrl) {
 		qphy_setbits(dp_com, QPHY_V3_DP_COM_POWER_DOWN_CTRL,
@@ -4430,10 +4428,8 @@ static int __maybe_unused qcom_qmp_phy_runtime_resume(struct device *dev)
 	}
 
 	ret = clk_bulk_prepare_enable(cfg->num_clks, qmp->clks);
-	if (ret) {
-		dev_err(qmp->dev, "failed to enable clks, err=%d\n", ret);
+	if (ret)
 		return ret;
-	}
 
 	ret = clk_prepare_enable(qphy->pipe_clk);
 	if (ret) {
-- 
2.18.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] phy: qcom-qmp: remove redundant error of clock bulk
  2021-05-17  5:37 [PATCH v2] phy: qcom-qmp: remove redundant error of clock bulk Chunfeng Yun
@ 2021-05-31  8:20 ` Vinod Koul
  0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2021-05-31  8:20 UTC (permalink / raw)
  To: Chunfeng Yun
  Cc: Kishon Vijay Abraham I, Andy Gross, Bjorn Andersson,
	Matthias Brugger, linux-arm-msm, linux-phy, linux-kernel,
	linux-arm-kernel, linux-mediatek

On 17-05-21, 13:37, Chunfeng Yun wrote:
> There is error log in clk_bulk_prepare/enable()
> 

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-31  8:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-17  5:37 [PATCH v2] phy: qcom-qmp: remove redundant error of clock bulk Chunfeng Yun
2021-05-31  8:20 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).