linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next v2] net: qrtr: ns: Fix error return code in qrtr_ns_init()
@ 2021-05-19 15:58 Wei Yongjun
  2021-05-19 20:20 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2021-05-19 15:58 UTC (permalink / raw)
  To: weiyongjun1, Manivannan Sadhasivam, David S. Miller, Jakub Kicinski
  Cc: linux-arm-msm, netdev, kernel-janitors, Hulk Robot,
	Manivannan Sadhasivam

Fix to return a negative error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: c6e08d6251f3 ("net: qrtr: Allocate workqueue before kernel_bind")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
v1 -> v2: add fixes tag and reviewed-by
---
 net/qrtr/ns.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/net/qrtr/ns.c b/net/qrtr/ns.c
index 8d00dfe8139e..1990d496fcfc 100644
--- a/net/qrtr/ns.c
+++ b/net/qrtr/ns.c
@@ -775,8 +775,10 @@ int qrtr_ns_init(void)
 	}
 
 	qrtr_ns.workqueue = alloc_workqueue("qrtr_ns_handler", WQ_UNBOUND, 1);
-	if (!qrtr_ns.workqueue)
+	if (!qrtr_ns.workqueue) {
+		ret = -ENOMEM;
 		goto err_sock;
+	}
 
 	qrtr_ns.sock->sk->sk_data_ready = qrtr_ns_data_ready;
 


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next v2] net: qrtr: ns: Fix error return code in qrtr_ns_init()
  2021-05-19 15:58 [PATCH net-next v2] net: qrtr: ns: Fix error return code in qrtr_ns_init() Wei Yongjun
@ 2021-05-19 20:20 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-05-19 20:20 UTC (permalink / raw)
  To: Wei Yongjun
  Cc: mani, davem, kuba, linux-arm-msm, netdev, kernel-janitors,
	hulkci, manivannan.sadhasivam

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 19 May 2021 15:58:52 +0000 you wrote:
> Fix to return a negative error code -ENOMEM from the error handling
> case instead of 0, as done elsewhere in this function.
> 
> Fixes: c6e08d6251f3 ("net: qrtr: Allocate workqueue before kernel_bind")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> 
> [...]

Here is the summary with links:
  - [net-next,v2] net: qrtr: ns: Fix error return code in qrtr_ns_init()
    https://git.kernel.org/netdev/net-next/c/a49e72b3bda7

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-19 20:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-19 15:58 [PATCH net-next v2] net: qrtr: ns: Fix error return code in qrtr_ns_init() Wei Yongjun
2021-05-19 20:20 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).