linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/msm/adreno: a5xx_power: Don't apply A540 lm_setup to other GPUs
@ 2021-02-28 12:36 Konrad Dybcio
  2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
  0 siblings, 1 reply; 2+ messages in thread
From: Konrad Dybcio @ 2021-02-28 12:36 UTC (permalink / raw)
  To: phone-devel
  Cc: ~postmarketos/upstreaming, martin.botka,
	angelogioacchino.delregno, marijn.suijten, Konrad Dybcio,
	Rob Clark, Sean Paul, David Airlie, Daniel Vetter, Jordan Crouse,
	linux-arm-msm, dri-devel, freedreno, linux-kernel

While passing the A530-specific lm_setup func to A530 and A540
to !A530 was fine back when only these two were supported, it
certainly is not a good idea to send A540 specifics to smaller
GPUs like A508 and friends.

Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
---
 drivers/gpu/drm/msm/adreno/a5xx_power.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/adreno/a5xx_power.c b/drivers/gpu/drm/msm/adreno/a5xx_power.c
index f176a6f3eff6..e58670a61df4 100644
--- a/drivers/gpu/drm/msm/adreno/a5xx_power.c
+++ b/drivers/gpu/drm/msm/adreno/a5xx_power.c
@@ -304,7 +304,7 @@ int a5xx_power_init(struct msm_gpu *gpu)
 	/* Set up the limits management */
 	if (adreno_is_a530(adreno_gpu))
 		a530_lm_setup(gpu);
-	else
+	else if (adreno_is_a540(adreno_gpu))
 		a540_lm_setup(gpu);
 
 	/* Set up SP/TP power collpase */
-- 
2.30.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/msm/adreno: a5xx_power: Don't apply A540 lm_setup to other GPUs
  2021-02-28 12:36 [PATCH] drm/msm/adreno: a5xx_power: Don't apply A540 lm_setup to other GPUs Konrad Dybcio
@ 2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+linux-arm-msm @ 2021-05-26 19:03 UTC (permalink / raw)
  To: Konrad Dybcio; +Cc: linux-arm-msm

Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

On Sun, 28 Feb 2021 13:36:51 +0100 you wrote:
> While passing the A530-specific lm_setup func to A530 and A540
> to !A530 was fine back when only these two were supported, it
> certainly is not a good idea to send A540 specifics to smaller
> GPUs like A508 and friends.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> 
> [...]

Here is the summary with links:
  - drm/msm/adreno: a5xx_power: Don't apply A540 lm_setup to other GPUs
    https://git.kernel.org/qcom/c/4a9d36b0610a

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-26 19:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-28 12:36 [PATCH] drm/msm/adreno: a5xx_power: Don't apply A540 lm_setup to other GPUs Konrad Dybcio
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).