* [PATCH][next] soundwire: qcom: Fix a u8 comparison with less than zero
@ 2021-03-31 14:09 Colin King
2021-03-31 18:32 ` Bjorn Andersson
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2021-03-31 14:09 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Vinod Koul, Bard Liao, Sanyog Kale,
Srinivas Kandagatla, linux-arm-msm, alsa-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable devnum is being checked for a less than zero error return
however the comparison will always be false because devnum is an 8 bit
unsigned integer. Fix this by making devnum an int. Also there is no
need to iniitialize devnum with zero as this value is no read, so
remove the redundant assignment.
Addresses-Coverity: ("Unsigned compared against 0")
Fixes: c7d49c76d1d5 ("soundwire: qcom: add support to new interrupts")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/soundwire/qcom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index b08ecb9b418c..ec86c4e53fdb 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -428,7 +428,7 @@ static irqreturn_t qcom_swrm_irq_handler(int irq, void *dev_id)
struct qcom_swrm_ctrl *swrm = dev_id;
u32 value, intr_sts, intr_sts_masked, slave_status;
u32 i;
- u8 devnum = 0;
+ int devnum;
int ret = IRQ_HANDLED;
swrm->reg_read(swrm, SWRM_INTERRUPT_STATUS, &intr_sts);
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] soundwire: qcom: Fix a u8 comparison with less than zero
2021-03-31 14:09 [PATCH][next] soundwire: qcom: Fix a u8 comparison with less than zero Colin King
@ 2021-03-31 18:32 ` Bjorn Andersson
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2021-03-31 18:32 UTC (permalink / raw)
To: Colin King
Cc: Andy Gross, Vinod Koul, Bard Liao, Sanyog Kale,
Srinivas Kandagatla, linux-arm-msm, alsa-devel, kernel-janitors,
linux-kernel
On Wed 31 Mar 09:09 CDT 2021, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable devnum is being checked for a less than zero error return
> however the comparison will always be false because devnum is an 8 bit
> unsigned integer. Fix this by making devnum an int. Also there is no
> need to iniitialize devnum with zero as this value is no read, so
> remove the redundant assignment.
>
> Addresses-Coverity: ("Unsigned compared against 0")
> Fixes: c7d49c76d1d5 ("soundwire: qcom: add support to new interrupts")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/soundwire/qcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
> index b08ecb9b418c..ec86c4e53fdb 100644
> --- a/drivers/soundwire/qcom.c
> +++ b/drivers/soundwire/qcom.c
> @@ -428,7 +428,7 @@ static irqreturn_t qcom_swrm_irq_handler(int irq, void *dev_id)
> struct qcom_swrm_ctrl *swrm = dev_id;
> u32 value, intr_sts, intr_sts_masked, slave_status;
> u32 i;
> - u8 devnum = 0;
> + int devnum;
> int ret = IRQ_HANDLED;
>
> swrm->reg_read(swrm, SWRM_INTERRUPT_STATUS, &intr_sts);
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] soundwire: qcom: Fix a u8 comparison with less than zero
2021-03-31 14:09 [PATCH][next] soundwire: qcom: Fix a u8 comparison with less than zero Colin King
2021-03-31 18:32 ` Bjorn Andersson
@ 2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+linux-arm-msm @ 2021-05-26 19:03 UTC (permalink / raw)
To: Colin King; +Cc: linux-arm-msm
Hello:
This patch was applied to qcom/linux.git (refs/heads/for-next):
On Wed, 31 Mar 2021 15:09:44 +0100 you wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable devnum is being checked for a less than zero error return
> however the comparison will always be false because devnum is an 8 bit
> unsigned integer. Fix this by making devnum an int. Also there is no
> need to iniitialize devnum with zero as this value is no read, so
> remove the redundant assignment.
>
> [...]
Here is the summary with links:
- [next] soundwire: qcom: Fix a u8 comparison with less than zero
https://git.kernel.org/qcom/c/b26b48749b18
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-26 19:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-31 14:09 [PATCH][next] soundwire: qcom: Fix a u8 comparison with less than zero Colin King
2021-03-31 18:32 ` Bjorn Andersson
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).