linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] media: camss: ispif: Remove redundant dev_err call in msm_ispif_subdev_init()
@ 2021-04-09  5:06 Yang Yingliang
  2021-04-09  9:09 ` Robert Foss
  2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
  0 siblings, 2 replies; 3+ messages in thread
From: Yang Yingliang @ 2021-04-09  5:06 UTC (permalink / raw)
  To: linux-kernel, linux-media, linux-arm-msm; +Cc: robert.foss, todor.too, mchehab

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/media/platform/qcom/camss/camss-ispif.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/media/platform/qcom/camss/camss-ispif.c b/drivers/media/platform/qcom/camss/camss-ispif.c
index a30e453de162..37611c8861da 100644
--- a/drivers/media/platform/qcom/camss/camss-ispif.c
+++ b/drivers/media/platform/qcom/camss/camss-ispif.c
@@ -1145,17 +1145,13 @@ int msm_ispif_subdev_init(struct camss *camss,
 
 	r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[0]);
 	ispif->base = devm_ioremap_resource(dev, r);
-	if (IS_ERR(ispif->base)) {
-		dev_err(dev, "could not map memory\n");
+	if (IS_ERR(ispif->base))
 		return PTR_ERR(ispif->base);
-	}
 
 	r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[1]);
 	ispif->base_clk_mux = devm_ioremap_resource(dev, r);
-	if (IS_ERR(ispif->base_clk_mux)) {
-		dev_err(dev, "could not map memory\n");
+	if (IS_ERR(ispif->base_clk_mux))
 		return PTR_ERR(ispif->base_clk_mux);
-	}
 
 	/* Interrupt */
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] media: camss: ispif: Remove redundant dev_err call in msm_ispif_subdev_init()
  2021-04-09  5:06 [PATCH -next] media: camss: ispif: Remove redundant dev_err call in msm_ispif_subdev_init() Yang Yingliang
@ 2021-04-09  9:09 ` Robert Foss
  2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
  1 sibling, 0 replies; 3+ messages in thread
From: Robert Foss @ 2021-04-09  9:09 UTC (permalink / raw)
  To: Yang Yingliang
  Cc: linux-kernel, linux-media, MSM, Todor Tomov, Mauro Carvalho Chehab

Hi Yang,

Thanks for the patch.

On Fri, 9 Apr 2021 at 07:03, Yang Yingliang <yangyingliang@huawei.com> wrote:
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/media/platform/qcom/camss/camss-ispif.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-ispif.c b/drivers/media/platform/qcom/camss/camss-ispif.c
> index a30e453de162..37611c8861da 100644
> --- a/drivers/media/platform/qcom/camss/camss-ispif.c
> +++ b/drivers/media/platform/qcom/camss/camss-ispif.c
> @@ -1145,17 +1145,13 @@ int msm_ispif_subdev_init(struct camss *camss,
>
>         r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[0]);
>         ispif->base = devm_ioremap_resource(dev, r);
> -       if (IS_ERR(ispif->base)) {
> -               dev_err(dev, "could not map memory\n");
> +       if (IS_ERR(ispif->base))
>                 return PTR_ERR(ispif->base);
> -       }
>
>         r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[1]);
>         ispif->base_clk_mux = devm_ioremap_resource(dev, r);
> -       if (IS_ERR(ispif->base_clk_mux)) {
> -               dev_err(dev, "could not map memory\n");
> +       if (IS_ERR(ispif->base_clk_mux))
>                 return PTR_ERR(ispif->base_clk_mux);
> -       }
>
>         /* Interrupt */
>

Reviewed-by: Robert Foss <robert.foss@linaro.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] media: camss: ispif: Remove redundant dev_err call in msm_ispif_subdev_init()
  2021-04-09  5:06 [PATCH -next] media: camss: ispif: Remove redundant dev_err call in msm_ispif_subdev_init() Yang Yingliang
  2021-04-09  9:09 ` Robert Foss
@ 2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+linux-arm-msm @ 2021-05-26 19:03 UTC (permalink / raw)
  To: Yang Yingliang; +Cc: linux-arm-msm

Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

On Fri, 9 Apr 2021 13:06:33 +0800 you wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> 
> [...]

Here is the summary with links:
  - [-next] media: camss: ispif: Remove redundant dev_err call in msm_ispif_subdev_init()
    https://git.kernel.org/qcom/c/a24bbbf24d9c

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-26 19:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09  5:06 [PATCH -next] media: camss: ispif: Remove redundant dev_err call in msm_ispif_subdev_init() Yang Yingliang
2021-04-09  9:09 ` Robert Foss
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).