linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: Disable PON on Trogdor
@ 2021-06-01 18:44 Stephen Boyd
  2021-06-02 16:59 ` Doug Anderson
  2021-06-10 14:50 ` patchwork-bot+linux-arm-msm
  0 siblings, 2 replies; 3+ messages in thread
From: Stephen Boyd @ 2021-06-01 18:44 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson; +Cc: linux-kernel, linux-arm-msm, Douglas Anderson

We don't use the PON module on Trogdor devices. Instead the reboot
reason is sort of stored in the 'eventlog' and the bootloader figures
out if the boot is abnormal and records that there. Disable the PON node
and then drop the power key disabling because that's a child node that
will no longer be enabled if the PON node is disabled.

Cc: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
 arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index 24d293ef56d7..cbde625cbea2 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -805,7 +805,7 @@ charger-thermistor@0 {
 	};
 };
 
-&pm6150_pwrkey {
+&pm6150_pon {
 	status = "disabled";
 };
 

base-commit: d07f6ca923ea0927a1024dfccafc5b53b61cfecc
-- 
https://chromeos.dev


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: Disable PON on Trogdor
  2021-06-01 18:44 [PATCH] arm64: dts: qcom: Disable PON on Trogdor Stephen Boyd
@ 2021-06-02 16:59 ` Doug Anderson
  2021-06-10 14:50 ` patchwork-bot+linux-arm-msm
  1 sibling, 0 replies; 3+ messages in thread
From: Doug Anderson @ 2021-06-02 16:59 UTC (permalink / raw)
  To: Stephen Boyd
  Cc: Andy Gross, Bjorn Andersson, LKML, linux-arm-msm, Rajendra Nayak

Hi,

On Tue, Jun 1, 2021 at 11:44 AM Stephen Boyd <swboyd@chromium.org> wrote:
>
> We don't use the PON module on Trogdor devices. Instead the reboot
> reason is sort of stored in the 'eventlog' and the bootloader figures
> out if the boot is abnormal and records that there. Disable the PON node
> and then drop the power key disabling because that's a child node that
> will no longer be enabled if the PON node is disabled.
>
> Cc: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
>  arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Right. So essentially you're saying that the bootloader on trogdor
(coreboot / depthcharge) doesn't do anything with this and thus it
doesn't make sense on this board. That sounds right to me. Basically
there's no way in userspace to tell the bootloader to reboot into
recovery mode or developer mode. Those things need to be initiated
manually by the user.

It's possible that Qualcomm internally has some out-of-tree patches
where they use the PON for ramdump mode. +Rajendra as an FYI in case
there's somehow he should give a heads up to about this.

Reviewed-by: Douglas Anderson <dianders@chromium.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: Disable PON on Trogdor
  2021-06-01 18:44 [PATCH] arm64: dts: qcom: Disable PON on Trogdor Stephen Boyd
  2021-06-02 16:59 ` Doug Anderson
@ 2021-06-10 14:50 ` patchwork-bot+linux-arm-msm
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+linux-arm-msm @ 2021-06-10 14:50 UTC (permalink / raw)
  To: Stephen Boyd; +Cc: linux-arm-msm

Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

On Tue,  1 Jun 2021 11:44:17 -0700 you wrote:
> We don't use the PON module on Trogdor devices. Instead the reboot
> reason is sort of stored in the 'eventlog' and the bootloader figures
> out if the boot is abnormal and records that there. Disable the PON node
> and then drop the power key disabling because that's a child node that
> will no longer be enabled if the PON node is disabled.
> 
> Cc: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> 
> [...]

Here is the summary with links:
  - arm64: dts: qcom: Disable PON on Trogdor
    https://git.kernel.org/qcom/c/d141e0524e8e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-10 14:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-01 18:44 [PATCH] arm64: dts: qcom: Disable PON on Trogdor Stephen Boyd
2021-06-02 16:59 ` Doug Anderson
2021-06-10 14:50 ` patchwork-bot+linux-arm-msm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).