From: Rob Herring <robh@kernel.org>
To: Caleb Connolly <caleb@connolly.tech>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-input@vger.kernel.org, phone-devel@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH 1/4] dt-bindings: input: add Qualcomm QPNP haptics driver
Date: Mon, 14 Jun 2021 07:39:48 -0600 [thread overview]
Message-ID: <1623677988.130611.630748.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20210612205405.1233588-2-caleb@connolly.tech>
On Sat, 12 Jun 2021 20:54:31 +0000, Caleb Connolly wrote:
> Add bindings for pmi8998 qpnp haptics driver.
>
> Signed-off-by: Caleb Connolly <caleb@connolly.tech>
> ---
> .../bindings/input/qcom,qpnp-haptics.yaml | 123 ++++++++++++++++++
> include/dt-bindings/input/qcom,qpnp-haptics.h | 31 +++++
> 2 files changed, 154 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/qcom,qpnp-haptics.yaml
> create mode 100644 include/dt-bindings/input/qcom,qpnp-haptics.h
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/input/qcom,qpnp-haptics.example.dt.yaml:0:0: /example-0/pmic@3: failed to match any schema with compatible: ['qcom,pmi8998', 'qcom,spmi-pmic']
Documentation/devicetree/bindings/input/qcom,qpnp-haptics.example.dt.yaml:0:0: /example-0/pmic@3: failed to match any schema with compatible: ['qcom,pmi8998', 'qcom,spmi-pmic']
\ndoc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1491323
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2021-06-14 13:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-12 20:54 input: Introduce QPNP (Qualcomm Plug n Play) haptics found on qcom PMICs Caleb Connolly
2021-06-12 20:54 ` [PATCH 1/4] dt-bindings: input: add Qualcomm QPNP haptics driver Caleb Connolly
2021-06-13 4:18 ` Bjorn Andersson
2021-06-14 13:39 ` Rob Herring [this message]
2021-06-12 20:54 ` [PATCH 2/4] " Caleb Connolly
2021-06-13 4:09 ` Bjorn Andersson
2021-06-13 16:24 ` Caleb Connolly
2021-06-13 17:11 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1623677988.130611.630748.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=caleb@connolly.tech \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).