linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bhaumik Bhatt <bbhatt@codeaurora.org>
To: manivannan.sadhasivam@linaro.org
Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org,
	jhugo@codeaurora.org, linux-kernel@vger.kernel.org,
	carl.yin@quectel.com, naveen.kumar@quectel.com,
	loic.poulain@linaro.org, Bhaumik Bhatt <bbhatt@codeaurora.org>
Subject: [PATCH v1 2/4] bus: mhi: pci_generic: Use enum entry for event ring priority
Date: Thu, 17 Jun 2021 14:30:33 -0700	[thread overview]
Message-ID: <1623965435-30224-3-git-send-email-bbhatt@codeaurora.org> (raw)
In-Reply-To: <1623965435-30224-1-git-send-email-bbhatt@codeaurora.org>

Instead of using a default event ring priority of 1, use the enum
provided and set it to default.

Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
---
 drivers/bus/mhi/pci_generic.c | 66 +++++++++++++++++++++----------------------
 1 file changed, 33 insertions(+), 33 deletions(-)

diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
index 31360a2..5886547 100644
--- a/drivers/bus/mhi/pci_generic.c
+++ b/drivers/bus/mhi/pci_generic.c
@@ -74,17 +74,17 @@ struct mhi_pci_dev_info {
 		.doorbell_mode_switch = false,		\
 	}
 
-#define MHI_EVENT_CONFIG_CTRL(ev_ring, el_count) \
-	{					\
-		.num_elements = el_count,	\
-		.irq_moderation_ms = 0,		\
-		.irq = (ev_ring) + 1,		\
-		.priority = 1,			\
-		.mode = MHI_DB_BRST_DISABLE,	\
-		.data_type = MHI_ER_CTRL,	\
-		.hardware_event = false,	\
-		.client_managed = false,	\
-		.offload_channel = false,	\
+#define MHI_EVENT_CONFIG_CTRL(ev_ring, el_count)	\
+	{						\
+		.num_elements = el_count,		\
+		.irq_moderation_ms = 0,			\
+		.irq = (ev_ring) + 1,			\
+		.priority = MHI_ER_PRIORITY_DEFAULT,	\
+		.mode = MHI_DB_BRST_DISABLE,		\
+		.data_type = MHI_ER_CTRL,		\
+		.hardware_event = false,		\
+		.client_managed = false,		\
+		.offload_channel = false,		\
 	}
 
 #define MHI_CHANNEL_CONFIG_HW_UL(ch_num, ch_name, el_count, ev_ring) \
@@ -177,31 +177,31 @@ struct mhi_pci_dev_info {
 		.doorbell_mode_switch = false,		\
 	}
 
-#define MHI_EVENT_CONFIG_DATA(ev_ring, el_count) \
-	{					\
-		.num_elements = el_count,	\
-		.irq_moderation_ms = 5,		\
-		.irq = (ev_ring) + 1,		\
-		.priority = 1,			\
-		.mode = MHI_DB_BRST_DISABLE,	\
-		.data_type = MHI_ER_DATA,	\
-		.hardware_event = false,	\
-		.client_managed = false,	\
-		.offload_channel = false,	\
+#define MHI_EVENT_CONFIG_DATA(ev_ring, el_count)	\
+	{						\
+		.num_elements = el_count,		\
+		.irq_moderation_ms = 5,			\
+		.irq = (ev_ring) + 1,			\
+		.priority = MHI_ER_PRIORITY_DEFAULT,	\
+		.mode = MHI_DB_BRST_DISABLE,		\
+		.data_type = MHI_ER_DATA,		\
+		.hardware_event = false,		\
+		.client_managed = false,		\
+		.offload_channel = false,		\
 	}
 
 #define MHI_EVENT_CONFIG_HW_DATA(ev_ring, el_count, ch_num) \
-	{					\
-		.num_elements = el_count,	\
-		.irq_moderation_ms = 1,		\
-		.irq = (ev_ring) + 1,		\
-		.priority = 1,			\
-		.mode = MHI_DB_BRST_DISABLE,	\
-		.data_type = MHI_ER_DATA,	\
-		.hardware_event = true,		\
-		.client_managed = false,	\
-		.offload_channel = false,	\
-		.channel = ch_num,		\
+	{						\
+		.num_elements = el_count,		\
+		.irq_moderation_ms = 1,			\
+		.irq = (ev_ring) + 1,			\
+		.priority = MHI_ER_PRIORITY_DEFAULT,	\
+		.mode = MHI_DB_BRST_DISABLE,		\
+		.data_type = MHI_ER_DATA,		\
+		.hardware_event = true,			\
+		.client_managed = false,		\
+		.offload_channel = false,		\
+		.channel = ch_num,			\
 	}
 
 static const struct mhi_channel_config modem_qcom_v1_mhi_channels[] = {
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


  parent reply	other threads:[~2021-06-17 21:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17 21:30 [PATCH v1 0/4] MHI event ring priority updates Bhaumik Bhatt
2021-06-17 21:30 ` [PATCH v1 1/4] bus: mhi: core: Add support for processing priority of event ring Bhaumik Bhatt
2021-06-18  7:03   ` Manivannan Sadhasivam
2021-06-18 17:17     ` Bhaumik Bhatt
2021-06-18 17:31       ` Manivannan Sadhasivam
2021-06-18 17:43         ` Bhaumik Bhatt
2021-06-17 21:30 ` Bhaumik Bhatt [this message]
2021-06-17 22:21   ` [PATCH v1 2/4] bus: mhi: pci_generic: Use enum entry for event ring priority Hemant Kumar
2021-06-17 21:30 ` [PATCH v1 3/4] ath11k: " Bhaumik Bhatt
2021-06-17 21:30 ` [PATCH v1 4/4] bus: mhi: core: Enable support for event ring priorities Bhaumik Bhatt
2021-06-17 22:20   ` Hemant Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1623965435-30224-3-git-send-email-bbhatt@codeaurora.org \
    --to=bbhatt@codeaurora.org \
    --cc=carl.yin@quectel.com \
    --cc=hemantk@codeaurora.org \
    --cc=jhugo@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=naveen.kumar@quectel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).