linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
	Iskren Chernev <iskren.chernev@gmail.com>
Cc: Andy Gross <agross@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht,
	Iskren Chernev <iskren.chernev@gmail.com>
Subject: Re: [PATCH v2 2/2] clk: qcom: Add Global Clock controller (GCC) driver for SM6115
Date: Tue, 27 Jul 2021 11:33:46 -0700	[thread overview]
Message-ID: <162741082663.2368309.12852214008454271169@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20210627185538.690277-3-iskren.chernev@gmail.com>

Quoting Iskren Chernev (2021-06-27 11:55:38)
> diff --git a/drivers/clk/qcom/gcc-sm6115.c b/drivers/clk/qcom/gcc-sm6115.c
> new file mode 100644
> index 000000000000..e3c830b33dec
> --- /dev/null
> +++ b/drivers/clk/qcom/gcc-sm6115.c
> @@ -0,0 +1,3623 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (c) 2019-2021, The Linux Foundation. All rights reserved.
> + */
> +
> +#include <linux/err.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/regmap.h>
> +#include <linux/reset-controller.h>

Should be clk-provider.h in this list as well.

> +
> +#include <dt-bindings/clock/qcom,gcc-sm6115.h>
> +
> +#include "clk-alpha-pll.h"
> +#include "clk-branch.h"
> +#include "clk-pll.h"
> +#include "clk-rcg.h"
> +#include "clk-regmap.h"
> +#include "clk-regmap-divider.h"
> +#include "common.h"
> +#include "gdsc.h"
> +#include "reset.h"
> +
> +enum {
> +       P_BI_TCXO,
> +       P_CORE_BI_PLL_TEST_SE,
> +       P_GPLL0_OUT_AUX2,
> +       P_GPLL0_OUT_EARLY,
> +       P_GPLL10_OUT_MAIN,
> +       P_GPLL11_OUT_AUX,
> +       P_GPLL11_OUT_AUX2,
> +       P_GPLL11_OUT_MAIN,
> +       P_GPLL3_OUT_EARLY,
> +       P_GPLL3_OUT_MAIN,
> +       P_GPLL4_OUT_MAIN,
> +       P_GPLL6_OUT_EARLY,
> +       P_GPLL6_OUT_MAIN,
> +       P_GPLL7_OUT_MAIN,
> +       P_GPLL8_OUT_EARLY,
> +       P_GPLL8_OUT_MAIN,
> +       P_GPLL9_OUT_EARLY,
> +       P_GPLL9_OUT_MAIN,
> +       P_SLEEP_CLK,
> +};
> +
> +static const struct parent_map gcc_parent_map_0[] = {
> +       { P_BI_TCXO, 0 },
> +       { P_GPLL0_OUT_EARLY, 1 },
> +       { P_GPLL0_OUT_AUX2, 2 },
> +       { P_CORE_BI_PLL_TEST_SE, 7 },
> +};
> +
> +static const char * const gcc_parent_names_0[] = {

Please use struct clk_parent_data instead of these arrays of strings.

> +       "bi_tcxo",
> +       "gpll0",
> +       "gpll0_out_aux2",
> +       "core_bi_pll_test_se",
> +};

And add newlines between structs.

> +static const char * const gcc_parent_names_0_ao[] = {
> +       "bi_tcxo_ao",
> +       "gpll0",
> +       "gpll0_out_aux2",
> +       "core_bi_pll_test_se",
> +};
> +

      reply	other threads:[~2021-07-27 18:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-27 18:55 [PATCH v2 0/2] Add GCC for SM4250/6115 Iskren Chernev
2021-06-27 18:55 ` [PATCH v2 1/2] dt-bindings: clk: qcom: gcc-sm6115: Document SM6115 GCC Iskren Chernev
2021-07-14 20:46   ` Rob Herring
2021-06-27 18:55 ` [PATCH v2 2/2] clk: qcom: Add Global Clock controller (GCC) driver for SM6115 Iskren Chernev
2021-07-27 18:33   ` Stephen Boyd [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=162741082663.2368309.12852214008454271169@swboyd.mtv.corp.google.com \
    --to=sboyd@kernel.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=iskren.chernev@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).