From: Stephen Boyd <sboyd@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
Michael Turquette <mturquette@baylibre.com>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@somainline.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Martin Botka <martin.botka@somainline.org>
Subject: Re: [PATCH v2] clk: qcom: gcc-sdm660: Replace usage of parent_names
Date: Sat, 28 Aug 2021 20:50:35 -0700 [thread overview]
Message-ID: <163020903534.2218116.16710170594346529772@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <08618b13-816b-7fc3-6ee6-fc222aef0607@somainline.org>
Quoting Marijn Suijten (2021-08-26 12:16:57)
> Hi Stephen,
>
> On 8/26/21 8:47 PM, Stephen Boyd wrote:
> > Quoting Bjorn Andersson (2021-08-25 13:45:17)
> >> Using parent_data and parent_hws, instead of parent_names, does protect
> >> against some cases of incompletely defined clock trees. While it turns
> >> out that the bug being chased this time was totally unrelated, this
> >> patch converts the SDM660 GCC driver to avoid such issues.
> >>
> >> The "xo" fixed_factor clock is unused within the gcc driver, but
> >> referenced from the DSI PHY. So it's left in place until the DSI driver
> >> is updated.
> >>
> >> Tested-by: Marijn Suijten <marijn.suijten@somainline.org>
> >> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> >> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
> >> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> >> ---
> >
> > Applied to clk-next after moving back the arrays so the diff is smaller.
> >
>
> Unfortunately the arrays cannot be moved back up since they (for the
> most part) reference gpll clocks in `.hw = &gpll*` fields - these have
> to be defined first or forward-declared otherwise, which is why the
> arrays were moved down in the first place.
>
> The general structure nowadays seems to place these parent maps/data
> right above the clock that uses them, making it easier to read.
>
Yes I applied a patch that only moved the arrays around first.
prev parent reply other threads:[~2021-08-29 3:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 20:45 [PATCH v2] clk: qcom: gcc-sdm660: Replace usage of parent_names Bjorn Andersson
2021-08-25 21:23 ` Marijn Suijten
2021-08-26 18:47 ` Stephen Boyd
2021-08-26 19:16 ` Marijn Suijten
2021-08-29 3:50 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163020903534.2218116.16710170594346529772@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).