* [PATCH linux-next] PCI: qcom-ep: Remove surplus dev_err() when using platform_get_irq_byname()
@ 2021-10-27 11:29 Krzysztof Wilczyński
2021-12-06 11:39 ` Lorenzo Pieralisi
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Wilczyński @ 2021-10-27 11:29 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Lorenzo Pieralisi, Manivannan Sadhasivam, linux-arm-msm, linux-pci
There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.
This change is as per suggestions from Coccinelle, e.g.,
drivers/pci/controller/dwc/pcie-qcom-ep.c:556:2-9: line 556 is redundant because platform_get_irq() already prints an error
Related:
https://lore.kernel.org/all/20210310131913.2802385-1-kw@linux.com/
https://lore.kernel.org/all/20200802142601.1635926-1-kw@linux.com/
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
---
drivers/pci/controller/dwc/pcie-qcom-ep.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c
index 7b17da2f9b3f..cdabd514dcc1 100644
--- a/drivers/pci/controller/dwc/pcie-qcom-ep.c
+++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c
@@ -552,10 +552,8 @@ static int qcom_pcie_ep_enable_irq_resources(struct platform_device *pdev,
int irq, ret;
irq = platform_get_irq_byname(pdev, "global");
- if (irq < 0) {
- dev_err(&pdev->dev, "Failed to get Global IRQ\n");
+ if (irq < 0)
return irq;
- }
ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
qcom_pcie_ep_global_irq_thread,
--
2.33.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH linux-next] PCI: qcom-ep: Remove surplus dev_err() when using platform_get_irq_byname()
2021-10-27 11:29 [PATCH linux-next] PCI: qcom-ep: Remove surplus dev_err() when using platform_get_irq_byname() Krzysztof Wilczyński
@ 2021-12-06 11:39 ` Lorenzo Pieralisi
0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Pieralisi @ 2021-12-06 11:39 UTC (permalink / raw)
To: Bjorn Helgaas, Krzysztof Wilczyński
Cc: Lorenzo Pieralisi, Manivannan Sadhasivam, linux-pci, linux-arm-msm
On Wed, 27 Oct 2021 11:29:31 +0000, Krzysztof Wilczyński wrote:
> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from either the platform_get_irq()
> or platform_get_irq_byname() functions as both are going to display an
> appropriate error message in case of a failure.
>
> This change is as per suggestions from Coccinelle, e.g.,
> drivers/pci/controller/dwc/pcie-qcom-ep.c:556:2-9: line 556 is redundant because platform_get_irq() already prints an error
>
> [...]
Applied to pci/dwc, thanks!
[1/1] PCI: qcom-ep: Remove surplus dev_err() when using platform_get_irq_byname()
https://git.kernel.org/lpieralisi/pci/c/549bf94dd2
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-06 11:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-27 11:29 [PATCH linux-next] PCI: qcom-ep: Remove surplus dev_err() when using platform_get_irq_byname() Krzysztof Wilczyński
2021-12-06 11:39 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).