From: khsieh@codeaurora.org
To: Stephen Boyd <swboyd@chromium.org>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
robdclark@gmail.com, sean@poorly.run, vkoul@kernel.org,
abhinavk@codeaurora.org, aravindh@codeaurora.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/2] drm/msm/dp: handle irq_hpd with sink_count = 0 correctly
Date: Fri, 21 May 2021 15:15:09 -0700 [thread overview]
Message-ID: <1698de8065945746fb165cb7647548f7@codeaurora.org> (raw)
In-Reply-To: <CAE-0n53WW0jqorW2MPaTczmJP+d+_qaRBcwmoJBP2dL4x8_DqA@mail.gmail.com>
On 2021-05-21 14:56, Stephen Boyd wrote:
> Quoting Kuogee Hsieh (2021-05-19 13:22:33)
>> irq_hpd interrupt should be handled after dongle plugged in and
>> before dongle unplugged. Hence irq_hpd interrupt is enabled at
>> the end of the plugin handle and disabled at the beginning of
>> unplugged handle. Current irq_hpd with sink_count = 0 is wrongly
>> handled same as the dongle unplugged which tears down the mainlink
>> and disables the phy. This patch fixes this problem by only tearing
>> down the mainlink but keeping phy enabled at irq_hpd with
>> sink_count = 0 handle so that next irq_hpd with sink_count =1 can be
>> handled by setup mainlink only. This patch also set dongle into D3
>> (power off) state at end of handling irq_hpd with sink_count = 0.
>>
>> Changes in v2:
>> -- add ctrl->phy_Power_count
>>
>> Changes in v3:
>> -- del ctrl->phy_Power_count
>> -- add phy_power_off to dp_ctrl_off_link_stream()
>>
>> Changes in v4:
>> -- return immediately if clock disable failed at
>> dp_ctrl_off_link_stream()
>>
>> Changes in v5:
>> -- set dongle to D3 (power off) state at dp_ctrl_off_link_stream()
>>
>> Changes in v6:
>> -- add Fixes tag
>>
>> Fixes: 94e58e2d06e3 ("drm/msm/dp: reset dp controller only at boot up
>> and pm_resume")
>>
>> Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org>
>> ---
>
> Tested-by: Stephen Boyd <swboyd@chromium.org>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>
> We can resolve the lingering dual irq issue later on if you don't want
> to send another round of this. Also, the title says 1/2 so I wonder if
> there's another patch? Doesn't look like there is but I have to ask. If
> not, please generate patches with the right -<N> argument or revision
> range.
ok, thanks,
Sorry, the 2nd patch is the xlog debug patch.
I did not submit it.
next prev parent reply other threads:[~2021-05-21 22:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 20:22 [PATCH v6 1/2] drm/msm/dp: handle irq_hpd with sink_count = 0 correctly Kuogee Hsieh
2021-05-21 21:56 ` Stephen Boyd
2021-05-21 22:15 ` khsieh [this message]
2021-05-21 22:27 ` khsieh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1698de8065945746fb165cb7647548f7@codeaurora.org \
--to=khsieh@codeaurora.org \
--cc=abhinavk@codeaurora.org \
--cc=agross@kernel.org \
--cc=aravindh@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).