From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5ECAC31E48 for ; Wed, 12 Jun 2019 09:49:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BFD72207E0 for ; Wed, 12 Jun 2019 09:49:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="EOISpQmt"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="jUP7os4j" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727677AbfFLJsz (ORCPT ); Wed, 12 Jun 2019 05:48:55 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:35540 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726636AbfFLJsz (ORCPT ); Wed, 12 Jun 2019 05:48:55 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 91AE96020A; Wed, 12 Jun 2019 09:48:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1560332934; bh=A5Q4nuwELYGPEsPIrnbKYM/7ycbeZUO8bLNEPplxKP4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=EOISpQmtkRdbP7TYk/oMunKmp9D5WZQeue2/qI4s4fUHYLUI2np6EqiJXzsbCgxiI +hNvMzvf3ZF8drF3xRrGeAofXI6+ZWWZW7qYJwLWiBMKSkrFBPd0C+w7HbGchpwv0R 9P7NXjypaMLC8dvkbdxUeaI9hoycPiMEQVDG1IuE= Received: from [10.201.2.161] (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sricharan@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3C82E6020A; Wed, 12 Jun 2019 09:48:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1560332933; bh=A5Q4nuwELYGPEsPIrnbKYM/7ycbeZUO8bLNEPplxKP4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=jUP7os4jcFN03veZ3Wr9rOflWS/Gv9t7t/DDs3/Phz04lxOI1I1IYZhP8GWkeKVLf HwdmFVVwUwBkfujUQfRazwZlcnCSsh3JK/jcPiN7azOgsylP/3i5ZIk0LEfhyTemIo AQ9C0FuhgdNv7w0foiPlGo4DXg4QIWDSUXVx6D30= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3C82E6020A Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sricharan@codeaurora.org Subject: Re: [PATCH 5/6] arm64: dts: Add ipq6018 SoC and CP01 board support To: Christian Lamparter Cc: Rob Herring , Stephen Boyd , Linus Walleij , agross@kernel.org, devicetree , linux-kernel , linux-clk@vger.kernel.org, "open list:GPIO SUBSYSTEM" , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-arm Mailing List , =?UTF-8?B?0J/QsNCy0LXQuw==?= References: <1559754961-26783-1-git-send-email-sricharan@codeaurora.org> <50231fba-7212-f8b9-9313-0c79294d4cc6@codeaurora.org> <4056907.DrFocau5Ix@debian64> From: Sricharan R Message-ID: <1a00e8c8-d07c-3b02-8ea5-6d5f3e2c7b1a@codeaurora.org> Date: Wed, 12 Jun 2019 15:18:48 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <4056907.DrFocau5Ix@debian64> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Christian, On 6/10/2019 5:45 PM, Christian Lamparter wrote: > On Monday, June 10, 2019 12:09:56 PM CEST Sricharan R wrote: >> Hi Christian, >> >> On 6/6/2019 2:11 AM, Christian Lamparter wrote: >>> On Wed, Jun 5, 2019 at 7:16 PM Sricharan R wrote: >>>> >>>> Add initial device tree support for the Qualcomm IPQ6018 SoC and >>>> CP01 evaluation board. >>>> >>>> Signed-off-by: Sricharan R >>>> Signed-off-by: Abhishek Sahu >>>> --- /dev/null >>>> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi >>>> >>>> + clocks { >>>> + sleep_clk: sleep_clk { >>>> + compatible = "fixed-clock"; >>>> + clock-frequency = <32000>; >>>> + #clock-cells = <0>; >>>> + }; >>>> + >>> Recently-ish, we ran into an issue with the clock-frequency of the sleep_clk >>> on older IPQ40XX (and IPQ806x) on the OpenWrt Github and ML. >>> From what I know, the external "32KHz" crystals have 32768 Hz, but the QSDK >>> declares them at 32000 Hz. Since you probably have access to the BOM and >>> datasheets. Can you please confirm what's the real clock frequency for >>> the IPQ6018. >>> (And maybe also for the sleep_clk of the IPQ4018 as well?). >>> >> >> What exactly is the issue that you faced ? >> Looking in to the docs, it is <32000> only on ipq6018 and ipq40xx as well. > > We need just a confirmation. > > Then again, Currently the qcom-ipq4019.dtsi is using 32768 Hz. > > | sleep_clk: sleep_clk { > | compatible = "fixed-clock"; > | clock-frequency = <32768>; > | #clock-cells = <0>; > | }; > > > > Which makes sense, because all previous Qualcomm Atheros MIPS and the > future IPQ8072 SoCs have been either using or deriving a 32768 Hz clock. > > For example: The AR9344 derives the clock from the 25MHz/40MHz external > oscillator. This is explained in "8.16.9 Derived RTC Clock (DERIVED_RTC_CLK)". > Which mentions that the "32KHz" clock interval is 30.5 usec / 30.48 usec > depending whenever the external reference crystal has 40MHz or 25MHz. > (1/30.5usec = 32.7868852 kilohertz!). The QCA9558 datasheet says the same > in "10.19.11 Derived RTC Clock". > > For IPQ8072: I point to the post by Sven Eckelmann on the OpenWrt ML: > > "I was only able to verify for IPQ8072 that it had a 32.768 KHz > sleep clock." > > So this is pretty much "why there is an issue", it's confusing. > Is possible can you please look if there are (fixed) divisors values > listed in the documentation or the registers and bits that the values > are stored in? Because then we could just calculate it. > Really sorry for the confusion. So looking little more, SLEEP_CLK is derived from an external 38.4MHZ crystal, it is 32.768 KHZ. Somehow the clk freq plan etc seems to mention them only as .032 MHZ and misses out. That means i will correct the patch for 32768 and probably the ipq8074.dtsi as well Regards, Sricharan -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation