From: Bhaumik Bhatt <bbhatt@codeaurora.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: manivannan.sadhasivam@linaro.org, hemantk@codeaurora.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/2] bus: mhi: pm: reduce PM state change verbosity
Date: Mon, 05 Apr 2021 11:51:21 -0700 [thread overview]
Message-ID: <1c2e88c2f4ba5c5fa1fbde8f1b06517e@codeaurora.org> (raw)
In-Reply-To: <1614963744-25962-2-git-send-email-loic.poulain@linaro.org>
On 2021-03-05 09:02 AM, Loic Poulain wrote:
> Since M3 can be entered/exited quite a lot when used for runtime PM,
> keep the mhi suspend/resume transitions quiet.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> ---
> drivers/bus/mhi/core/pm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
> index edd7794..0cd6445 100644
> --- a/drivers/bus/mhi/core/pm.c
> +++ b/drivers/bus/mhi/core/pm.c
> @@ -858,7 +858,7 @@ int mhi_pm_suspend(struct mhi_controller
> *mhi_cntrl)
> return -EBUSY;
> }
>
> - dev_info(dev, "Allowing M3 transition\n");
> + dev_dbg(dev, "Allowing M3 transition\n");
> new_state = mhi_tryset_pm_state(mhi_cntrl, MHI_PM_M3_ENTER);
> if (new_state != MHI_PM_M3_ENTER) {
> write_unlock_irq(&mhi_cntrl->pm_lock);
> @@ -872,7 +872,7 @@ int mhi_pm_suspend(struct mhi_controller
> *mhi_cntrl)
> /* Set MHI to M3 and wait for completion */
> mhi_set_mhi_state(mhi_cntrl, MHI_STATE_M3);
> write_unlock_irq(&mhi_cntrl->pm_lock);
> - dev_info(dev, "Wait for M3 completion\n");
> + dev_dbg(dev, "Wait for M3 completion\n");
>
> ret = wait_event_timeout(mhi_cntrl->state_event,
> mhi_cntrl->dev_state == MHI_STATE_M3 ||
> @@ -906,7 +906,7 @@ int mhi_pm_resume(struct mhi_controller *mhi_cntrl)
> enum mhi_pm_state cur_state;
> int ret;
>
> - dev_info(dev, "Entered with PM state: %s, MHI state: %s\n",
> + dev_dbg(dev, "Entered with PM state: %s, MHI state: %s\n",
> to_mhi_pm_state_str(mhi_cntrl->pm_state),
> TO_MHI_STATE_STR(mhi_cntrl->dev_state));
Since we go from 4 chars (info) to 3 chars (dbg), there is need to
adjust
the two parameters here in the next two lines, right?
If that's needed and is done, you can add my tag for:
Reviewed-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
We can just push this patch as a standalone one not dependent on the 1/2
in this series.
Thanks,
Bhaumik
---
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2021-04-05 18:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 17:02 [PATCH 1/2] bus: mhi: core: Fix MHI runtime_pm behavior Loic Poulain
2021-03-05 17:02 ` [PATCH 2/2] bus: mhi: pm: reduce PM state change verbosity Loic Poulain
2021-04-05 18:51 ` Bhaumik Bhatt [this message]
2021-03-31 17:12 ` [PATCH 1/2] bus: mhi: core: Fix MHI runtime_pm behavior Manivannan Sadhasivam
[not found] ` <CAMZdPi-M5fYPs7QfsBx4Gy6ywCLue5yqJLn0XthGhTeON1wWfw@mail.gmail.com>
2021-03-31 18:27 ` Manivannan Sadhasivam
2021-04-05 18:46 ` Bhaumik Bhatt
2021-04-06 3:54 ` Hemant Kumar
2021-04-06 8:29 ` Loic Poulain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c2e88c2f4ba5c5fa1fbde8f1b06517e@codeaurora.org \
--to=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).