From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE463C77B7A for ; Thu, 1 Jun 2023 16:50:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231926AbjFAQuL (ORCPT ); Thu, 1 Jun 2023 12:50:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232495AbjFAQtx (ORCPT ); Thu, 1 Jun 2023 12:49:53 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1602E49; Thu, 1 Jun 2023 09:49:47 -0700 (PDT) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 351CepqF019920; Thu, 1 Jun 2023 16:49:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=F3P7CnWt3JspS21qsK55wiKbb/5tikkox3+0vGUuWco=; b=VWd8mrvBDt61NJ8zmbZu5/gazoGrRUoY9y12I6pGfpPkpofQXsqfIPS7PllnQSBneC/Z NEjmRbKeIuR0YG7Mtw0uP47u9z8z92aG1caoDYrNpQ25npFUSlTVpPzKiOtp7rSfc+Ju vdUgKiXkcQzxjj/pd6Eh98pBgbDgFNDHaOUYPF0Re6nm1VmslroZmt6VCd2dEgAfraDj 7IEM2q4jseAhbGHBqADe7xJQrg/sTN/pt77FZ6Gi1QakQkYcWIovxBH7+LEYNx7rXbV3 DKO+tnLB17l5SBu5wESw55yoL92mwqI+Nt2ieKkqUj6KMxw0WuXXZ1bpQ8et0I9UvDhH HQ== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qxugr8pv5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Jun 2023 16:49:33 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 351GnWt9010176 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 1 Jun 2023 16:49:32 GMT Received: from [10.110.26.45] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Thu, 1 Jun 2023 09:49:26 -0700 Message-ID: <1e145484-2fe1-d5c6-6eb2-6be0b0fee27e@quicinc.com> Date: Thu, 1 Jun 2023 09:49:22 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2] drm/msm/dpu: clean up dpu_kms_get_clk_rate() returns Content-Language: en-US To: Dan Carpenter , Rob Clark CC: Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Marijn Suijten , "Konrad Dybcio" , Jessica Zhang , Liu Shixin , Douglas Anderson , , , , References: <28644c5e-950e-41cd-8389-67f37b067bdc@kili.mountain> From: Abhinav Kumar In-Reply-To: <28644c5e-950e-41cd-8389-67f37b067bdc@kili.mountain> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: g7kCdrVEBawogiPFf_5jC5lnfht0fYEV X-Proofpoint-ORIG-GUID: g7kCdrVEBawogiPFf_5jC5lnfht0fYEV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-01_08,2023-05-31_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 mlxscore=0 clxscore=1011 impostorscore=0 adultscore=0 malwarescore=0 phishscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2306010146 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 5/26/2023 4:51 AM, Dan Carpenter wrote: > Static analysis tools complain about the -EINVAL error code being > stored in an unsigned variable. Let's change this to match > the clk_get_rate() function which is type unsigned long and returns > zero on error. > > Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") > Signed-off-by: Dan Carpenter > --- > v2: In v1 I change the type to int which was wrong. This is a different > approach. CC the freedreno list this time too. > > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 4 ++-- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > index 0e7a68714e9e..25e6a15eaf9f 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > @@ -979,13 +979,13 @@ static int _dpu_kms_mmu_init(struct dpu_kms *dpu_kms) > return 0; > } > > -u64 dpu_kms_get_clk_rate(struct dpu_kms *dpu_kms, char *clock_name) > +unsigned long dpu_kms_get_clk_rate(struct dpu_kms *dpu_kms, char *clock_name) > { > struct clk *clk; > > clk = msm_clk_bulk_get_clock(dpu_kms->clocks, dpu_kms->num_clocks, clock_name); > if (!clk) > - return -EINVAL; > + return 0; > Currently, the only caller of this API is dpu_encoder_phys_cmd_tearcheck_config which seems to handle <=0 so this change should be fine. Hence Reviewed-by: Abhinav Kumar