On Tue, Mar 24, 2015 at 10:30:00PM +0000, Srinivas Kandagatla wrote: > + /* regmap_get_reg_stride(): Report the register address stride > + * > + * Report the register address stride, mainly intended to for use by > + * generic infrastructure built on top of regmap. > + */ > +int regmap_get_reg_stride(struct regmap *map) Please fix the indentation for the comment block and add kerneldoc for the argument. This is an exported function so it should also be /** not /*