On Mon, Mar 30, 2015 at 10:56:27PM +0100, Srinivas Kandagatla wrote: > +int regmap_get_max_register(struct regmap *map) > +{ > + return map->max_register ? : -EINVAL; > +} Please don't abuse the ternery operator like this, write a proper if statement that people can read.