On Mon, Mar 30, 2015 at 10:57:50PM +0100, Srinivas Kandagatla wrote: > + > + for (i = 0; i < cell->nblocks; i++) { > + rc = regmap_raw_read(eeprom->regmap, cell->blocks[i].offset, > + buf + offset, cell->blocks[i].count); I *think* this is probably OK but please double check that the count here is in bytes rather than words, it's a bit confusing since I'd read a count as being in words. Otherwise I think the regmap usage here all looks good.