From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Andy Gross <andy.gross@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-soc@vger.kernel.org
Subject: Re: [PATCH 06/12] ARM: dts: dragonboard-600c: Add eMMC and SD card support
Date: Tue, 29 Mar 2016 07:38:29 -0700 [thread overview]
Message-ID: <20160329143829.GJ8929@tuxbot> (raw)
In-Reply-To: <1458762458-9584-1-git-send-email-srinivas.kandagatla@linaro.org>
On Wed 23 Mar 12:47 PDT 2016, Srinivas Kandagatla wrote:
> This patch adds eMMC and SD card support with card detect and adding
> required regulators.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> .../arm/boot/dts/qcom-apq8064-dragonboard-600c.dts | 41 ++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8064-dragonboard-600c.dts b/arch/arm/boot/dts/qcom-apq8064-dragonboard-600c.dts
> index 0a0bcfe..a977314 100644
> --- a/arch/arm/boot/dts/qcom-apq8064-dragonboard-600c.dts
> +++ b/arch/arm/boot/dts/qcom-apq8064-dragonboard-600c.dts
> @@ -1,4 +1,5 @@
> #include "qcom-apq8064-v2.0.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
>
> / {
> model = "Qualcomm Technologies, Inc. APQ8064 DragonBoard600c";
> @@ -22,6 +23,16 @@
> };
>
> soc {
> + pinctrl@800000 {
> + card_detect: card_detect {
> + mux {
> + pins = "gpio26";
> + function = "gpio";
> + bias-disable;
> + };
> + };
> + };
> +
> rpm@108000 {
> regulators {
> vdd_l1_l2_l12_l18-supply = <&pm8921_s4>;
> @@ -62,6 +73,18 @@
> regulator-max-microvolt = <1300000>;
> qcom,switch-mode-frequency = <3200000>;
> };
> +
> + l5 {
> + regulator-min-microvolt = <2750000>;
> + regulator-max-microvolt = <3000000>;
> + bias-pull-down;
> + };
> +
> + l6 {
> + regulator-min-microvolt = <2950000>;
> + regulator-max-microvolt = <2950000>;
> + bias-pull-down;
> + };
I would prefer if you folded these into the regulator patch.
> };
> };
>
> @@ -87,5 +110,23 @@
> pinctrl-0 = <&gsbi7_uart_2pins>;
> };
> };
> +
> + amba {
> + /* eMMC */
> + sdcc@12400000 {
> + status = "okay";
> + vmmc-supply = <&pm8921_l5>;
> + vqmmc-supply = <&pm8921_s4>;
> + };
> +
> + /* External micro SD card */
> + sdcc@12180000 {
> + status = "okay";
> + vmmc-supply = <&pm8921_l6>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&card_detect>;
> + cd-gpios = <&tlmm_pinmux 26 GPIO_ACTIVE_HIGH>;
> + };
> + };
Other than that,
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
next prev parent reply other threads:[~2016-03-29 14:38 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 19:46 [PATCH 00/12] ARM: dts: Add dragonboard-600c support Srinivas Kandagatla
2016-03-23 19:47 ` [PATCH 01/12] ARM: dts: apq8064: fix the pinctrls for i2c and spi Srinivas Kandagatla
[not found] ` <1458762421-9339-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-03-29 14:28 ` Bjorn Andersson
2016-03-29 15:02 ` Srinivas Kandagatla
2016-03-29 16:10 ` Bjorn Andersson
2016-03-23 19:47 ` [PATCH 02/12] ARM: dts: apq8064: add support to gsbi1 uart Srinivas Kandagatla
[not found] ` <1458762429-9397-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-03-29 14:29 ` Bjorn Andersson
2016-03-23 19:47 ` [PATCH 03/12] ARM: dts: apq8064: add gsbi7 i2c support Srinivas Kandagatla
2016-03-29 14:34 ` Bjorn Andersson
2016-03-23 19:47 ` [PATCH 05/12] ARM: dts: dragonboard-600c: add pmic regulator supplies Srinivas Kandagatla
2016-03-29 14:37 ` Bjorn Andersson
2016-03-29 15:02 ` Srinivas Kandagatla
2016-03-23 19:47 ` [PATCH 06/12] ARM: dts: dragonboard-600c: Add eMMC and SD card support Srinivas Kandagatla
2016-03-29 14:38 ` Bjorn Andersson [this message]
2016-03-29 15:02 ` Srinivas Kandagatla
2016-03-23 19:47 ` [PATCH 07/12] ARM: dts: dragonboard-600c: add usb support Srinivas Kandagatla
2016-03-29 14:39 ` Bjorn Andersson
2016-03-23 19:47 ` [PATCH 08/12] ARM: dts: dragonboard-600c: add pcie support Srinivas Kandagatla
2016-03-29 14:39 ` Bjorn Andersson
2016-03-23 19:47 ` [PATCH 09/12] ARM: dts: dragonboard-600c: add on board sata support Srinivas Kandagatla
2016-03-29 14:40 ` Bjorn Andersson
2016-03-23 19:48 ` [PATCH 10/12] ARM: dts: dragonboard-600c: Add on board leds support Srinivas Kandagatla
2016-03-24 16:51 ` Nicolas Dechesne
2016-03-29 13:30 ` Srinivas Kandagatla
2016-03-27 5:50 ` Bjorn Andersson
2016-03-29 14:20 ` Srinivas Kandagatla
2016-03-29 14:51 ` Bjorn Andersson
2016-03-29 18:32 ` Nicolas Dechesne
[not found] ` <CAP71WjwPQn8OuCy+8iuQpDrUW2baQ0qzaviLEDixVzTmUP_BTw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-29 21:10 ` Bjorn Andersson
2016-03-30 12:54 ` Rob Herring
2016-03-23 19:48 ` [PATCH 11/12] ARM: dts: dragonboard-600c: add i2c support Srinivas Kandagatla
2016-03-29 14:44 ` Bjorn Andersson
2016-03-29 15:02 ` Srinivas Kandagatla
2016-03-23 19:48 ` [PATCH 12/12] ARM: dts: dragonboard-600c: add spi support Srinivas Kandagatla
[not found] ` <1458762366-9233-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-03-23 19:47 ` [PATCH 04/12] ARM: dts: dragonboard-600c: add board support with serial Srinivas Kandagatla
2016-03-23 20:07 ` Stephen Boyd
2016-03-23 20:30 ` Srinivas Kandagatla
[not found] ` <56F2FCD0.1000708-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-03-24 1:04 ` Bjorn Andersson
[not found] ` <CAOCOHw7TyzDf4jvAMChOFFEgsL4Z1+CcESLOuckT=Q7W9hQvCw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-24 1:48 ` Stephen Boyd
2016-03-24 12:49 ` Arnd Bergmann
2016-03-24 20:50 ` Nicolas Dechesne
2016-03-29 19:00 ` Stephen Boyd
2016-03-29 14:21 ` Bjorn Andersson
2016-03-29 14:54 ` [PATCH 00/12] ARM: dts: Add dragonboard-600c support Bjorn Andersson
2016-03-29 15:02 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329143829.GJ8929@tuxbot \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).