From: Andy Gross <andy.gross@linaro.org>
To: Sreedhar Sambangi <ssambang@codeaurora.org>
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
david.brown@linaro.org, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, linux@arm.linux.org.uk,
linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
qca-upstream.external@qca.qualcomm.com
Subject: Re: [PATCH 1/2] qcom: ipq4019: Add regulator support to DK04 device tree
Date: Tue, 5 Apr 2016 00:59:06 -0500 [thread overview]
Message-ID: <20160405055906.GB2639@hector> (raw)
In-Reply-To: <1459804090-31739-1-git-send-email-ssambang@codeaurora.org>
On Mon, Apr 04, 2016 at 02:08:10PM -0700, Sreedhar Sambangi wrote:
> This adds the regulator nodes to DK04 device tree to support
>
> Change-Id: I9c1df0e720a330bf6db1889fd2247f6a70ea6faa
> Signed-off-by: Sreedhar Sambangi <ssambang@codeaurora.org>
> ---
> .../bindings/regulator/ipq4019-regulator.txt | 19 +++++++++++++++++++
> arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi | 11 +++++++++++
> 2 files changed, 30 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/ipq4019-regulator.txt
>
> diff --git a/Documentation/devicetree/bindings/regulator/ipq4019-regulator.txt b/Documentation/devicetree/bindings/regulator/ipq4019-regulator.txt
> new file mode 100644
> index 0000000..9d934a4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/ipq4019-regulator.txt
> @@ -0,0 +1,19 @@
> +* Qualcomm Technologies, Inc. IPQ4019 regulators
> +
> +Required properties:
> +- compatible : Must be "regulator-ipq4019".
> +- states : Selection of available voltages and corresponding values
> +- reg : Register address for controlling LDO
> +- mask : Mask value for switching voltages
> +Example:
How many LDOs are there on the IPQ4019? Can you document all of the supplies?
You can figure this out by looking for the vdd pins in the chip documentation
> +
> + vccq_sd0: regulator@0 {
> + compatible = "qcom,regulator-ipq4019";
> + regulator-name = "SD0 VccQ";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3000000>;
> + states = <3000000 0x3
> + 1800000 0x1>;
So there are only 2 states? No linear range from 1.8 to 3.3?
> + reg = <0x01948000 0x4>;
> + mask = <0x3>;
> + };
next prev parent reply other threads:[~2016-04-05 5:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 21:08 [PATCH 1/2] qcom: ipq4019: Add regulator support to DK04 device tree Sreedhar Sambangi
2016-04-05 5:59 ` Andy Gross [this message]
2016-04-06 4:55 ` Sreedhar Sambangi
2016-04-07 17:57 ` Rob Herring
2016-04-07 18:11 ` Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160405055906.GB2639@hector \
--to=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=qca-upstream.external@qca.qualcomm.com \
--cc=robh+dt@kernel.org \
--cc=ssambang@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).