From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Chen Subject: Re: [PATCH v5 02/23] of: device: Export of_device_{get_modalias, uvent_modalias} to modules Date: Tue, 25 Oct 2016 09:16:32 +0800 Message-ID: <20161025011632.GA23876@b29397-desktop> References: <20161018015636.11701-1-stephen.boyd@linaro.org> <20161018015636.11701-3-stephen.boyd@linaro.org> <147733850401.29612.2343965740004706258@sboyd-linaro> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pf0-f195.google.com ([209.85.192.195]:36532 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758136AbcJYBQr (ORCPT ); Mon, 24 Oct 2016 21:16:47 -0400 Content-Disposition: inline In-Reply-To: <147733850401.29612.2343965740004706258@sboyd-linaro> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephen Boyd , robh@kernel.org Cc: Chen-Yu Tsai , Felipe Balbi , Arnd Bergmann , Neil Armstrong , linux-arm-msm@vger.kernel.org, linux-usb , linux-kernel , Bjorn Andersson , devicetree , Peter Chen , Andy Gross , linux-arm-kernel On Mon, Oct 24, 2016 at 12:48:24PM -0700, Stephen Boyd wrote: > Quoting Chen-Yu Tsai (2016-10-24 05:19:05) > > Hi, > > > > On Tue, Oct 18, 2016 at 9:56 AM, Stephen Boyd wrote: > > > The ULPI bus can be built as a module, and it will soon be > > > calling these functions when it supports probing devices from DT. > > > Export them so they can be used by the ULPI module. > > > > > > Acked-by: Rob Herring > > > Cc: > > > Signed-off-by: Stephen Boyd > > > --- > > > drivers/of/device.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/of/device.c b/drivers/of/device.c > > > index 8a22a253a830..6719ab35b62e 100644 > > > --- a/drivers/of/device.c > > > +++ b/drivers/of/device.c > > > @@ -225,6 +225,7 @@ ssize_t of_device_get_modalias(struct device *dev, char *str, ssize_t len) > > > > > > return tsize; > > > } > > > +EXPORT_SYMBOL_GPL(of_device_get_modalias); > > > > > > int of_device_request_module(struct device *dev) > > > { > > > @@ -290,6 +291,7 @@ void of_device_uevent(struct device *dev, struct kobj_uevent_env *env) > > > } > > > mutex_unlock(&of_mutex); > > > } > > > +EXPORT_SYMBOL_GPL(of_device_uevent_modalias); > > > > This is trailing the wrong function. > > > > Good catch. Must have been some bad rebase. > > Peter, can you fix it while applying or should I resend this patch? > But, this is device tree patch. I can only get chipidea part and other USB patches if Greg agrees. -- Best Regards, Peter Chen