From: Lina Iyer <lina.iyer@linaro.org>
To: ulf.hansson@linaro.org, khilman@kernel.org, rjw@rjwysocki.net,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: andy.gross@linaro.org, sboyd@codeaurora.org,
linux-arm-msm@vger.kernel.org, brendan.jackman@arm.com,
lorenzo.pieralisi@arm.com, sudeep.holla@arm.com,
Juri.Lelli@arm.com, devicetree@vger.kernel.org,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH] PM / Domains: Fix compatible for domain idle state
Date: Wed, 8 Feb 2017 09:42:42 -0700 [thread overview]
Message-ID: <20170208164242.GC2564@linaro.org> (raw)
In-Reply-To: <1486571692-33212-2-git-send-email-lina.iyer@linaro.org>
On Wed, Feb 08 2017 at 09:35 -0700, Lina Iyer wrote:
>Re-using idle state definition provided by arm,idle-state for domain
>idle states creates a lot of confusion and limits further evolution of
>the domain idle definition. To keep things clear and simple, define a
>idle states for domain using a new compatible "domain-idle-state".
>
>Fix existing PM domains code to look for the newly defined compatible.
>
>Cc: <devicetree@vger.kernel.org>
>Cc: Rob Herring <robh@kernel.org>
>Signed-off-by: Lina Iyer <lina.iyer@linaro.org>
Sorry, this has already been applied. Got tagged along with the email.
Kindly ignore.
Thanks,
Lina
>---
> .../bindings/power/domain-idle-state.txt | 33 ++++++++++++++++++++++
> .../devicetree/bindings/power/power_domain.txt | 8 +++---
> drivers/base/power/domain.c | 2 +-
> 3 files changed, 38 insertions(+), 5 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/power/domain-idle-state.txt
>
>diff --git a/Documentation/devicetree/bindings/power/domain-idle-state.txt b/Documentation/devicetree/bindings/power/domain-idle-state.txt
>new file mode 100644
>index 0000000..eefc7ed
>--- /dev/null
>+++ b/Documentation/devicetree/bindings/power/domain-idle-state.txt
>@@ -0,0 +1,33 @@
>+PM Domain Idle State Node:
>+
>+A domain idle state node represents the state parameters that will be used to
>+select the state when there are no active components in the domain.
>+
>+The state node has the following parameters -
>+
>+- compatible:
>+ Usage: Required
>+ Value type: <string>
>+ Definition: Must be "domain-idle-state".
>+
>+- entry-latency-us
>+ Usage: Required
>+ Value type: <prop-encoded-array>
>+ Definition: u32 value representing worst case latency in
>+ microseconds required to enter the idle state.
>+ The exit-latency-us duration may be guaranteed
>+ only after entry-latency-us has passed.
>+
>+- exit-latency-us
>+ Usage: Required
>+ Value type: <prop-encoded-array>
>+ Definition: u32 value representing worst case latency
>+ in microseconds required to exit the idle state.
>+
>+- min-residency-us
>+ Usage: Required
>+ Value type: <prop-encoded-array>
>+ Definition: u32 value representing minimum residency duration
>+ in microseconds after which the idle state will yield
>+ power benefits after overcoming the overhead in entering
>+i the idle state.
>diff --git a/Documentation/devicetree/bindings/power/power_domain.txt b/Documentation/devicetree/bindings/power/power_domain.txt
>index e165036..723e1ad 100644
>--- a/Documentation/devicetree/bindings/power/power_domain.txt
>+++ b/Documentation/devicetree/bindings/power/power_domain.txt
>@@ -31,7 +31,7 @@ Optional properties:
>
> - domain-idle-states : A phandle of an idle-state that shall be soaked into a
> generic domain power state. The idle state definitions are
>- compatible with arm,idle-state specified in [1].
>+ compatible with domain-idle-state specified in [1].
> The domain-idle-state property reflects the idle state of this PM domain and
> not the idle states of the devices or sub-domains in the PM domain. Devices
> and sub-domains have their own idle-states independent of the parent
>@@ -85,7 +85,7 @@ Example 3:
> };
>
> DOMAIN_RET: state@0 {
>- compatible = "arm,idle-state";
>+ compatible = "domain-idle-state";
> reg = <0x0>;
> entry-latency-us = <1000>;
> exit-latency-us = <2000>;
>@@ -93,7 +93,7 @@ Example 3:
> };
>
> DOMAIN_PWR_DN: state@1 {
>- compatible = "arm,idle-state";
>+ compatible = "domain-idle-state";
> reg = <0x1>;
> entry-latency-us = <5000>;
> exit-latency-us = <8000>;
>@@ -118,4 +118,4 @@ The node above defines a typical PM domain consumer device, which is located
> inside a PM domain with index 0 of a power controller represented by a node
> with the label "power".
>
>-[1]. Documentation/devicetree/bindings/arm/idle-states.txt
>+[1]. Documentation/devicetree/bindings/power/domain-idle-state.txt
>diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
>index 661737c..f0bc672 100644
>--- a/drivers/base/power/domain.c
>+++ b/drivers/base/power/domain.c
>@@ -2048,7 +2048,7 @@ int genpd_dev_pm_attach(struct device *dev)
> EXPORT_SYMBOL_GPL(genpd_dev_pm_attach);
>
> static const struct of_device_id idle_state_match[] = {
>- { .compatible = "arm,idle-state", },
>+ { .compatible = "domain-idle-state", },
> { }
> };
>
>--
>2.7.4
>
next prev parent reply other threads:[~2017-02-08 16:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 16:34 [PATCH 0/2] PM / Domains: Updates to IRQ safe PM domains Lina Iyer
2017-02-08 16:34 ` [PATCH] PM / Domains: Fix compatible for domain idle state Lina Iyer
2017-02-08 16:42 ` Lina Iyer [this message]
2017-02-08 16:34 ` [PATCH 1/2] PM / Domains: Ignore domain-idle-states that are not compatible Lina Iyer
2017-02-09 8:40 ` Ulf Hansson
2017-02-08 16:34 ` [PATCH 2/2] PM / Domains: Support in context powering off parent domain Lina Iyer
2017-02-09 9:02 ` Ulf Hansson
2017-02-09 9:03 ` Ulf Hansson
-- strict thread matches above, loose matches on Subject: below --
2016-11-03 21:54 [PATCH] PM / Domains: Fix for domain idle state Lina Iyer
2016-11-03 21:54 ` [PATCH] PM / Domains: Fix compatible " Lina Iyer
2016-11-07 11:14 ` Ulf Hansson
[not found] ` <CAPDyKFoCjf1qSBDWUY_wNx21_78fRrFqcqrFbsSmabzAZJxQAQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-11-10 19:58 ` Rob Herring
2016-11-11 11:52 ` Ulf Hansson
2016-11-29 8:47 ` Ulf Hansson
2016-12-01 21:21 ` Rafael J. Wysocki
[not found] ` <1616414.c1s7NxTqJS-yvgW3jdyMHm1GS7QM15AGw@public.gmane.org>
2016-12-08 0:13 ` Rafael J. Wysocki
2016-12-08 16:07 ` Rob Herring
[not found] ` <1478210075-92045-2-git-send-email-lina.iyer-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-11-21 12:37 ` Brendan Jackman
2016-11-21 13:11 ` Rafael J. Wysocki
2016-11-21 13:27 ` Ulf Hansson
2016-11-21 16:30 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170208164242.GC2564@linaro.org \
--to=lina.iyer@linaro.org \
--cc=Juri.Lelli@arm.com \
--cc=andy.gross@linaro.org \
--cc=brendan.jackman@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sudeep.holla@arm.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).