From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: "Dwivedi, Avaneesh Kumar (avani)" <akdwived@codeaurora.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
agross@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH v3 1/2] soc: qcom: Add support of scm call for mss rproc to share access of ddr
Date: Fri, 14 Apr 2017 10:59:24 -0700 [thread overview]
Message-ID: <20170414175924.GS70446@Bjorns-MacBook-Pro-2.local> (raw)
In-Reply-To: <a8123857-e4e8-e365-f982-65bd7b65fa02@codeaurora.org>
On Fri 14 Apr 07:01 PDT 2017, Dwivedi, Avaneesh Kumar (avani) wrote:
> On 4/6/2017 5:14 AM, Stephen Boyd wrote:
> > On 03/08, Avaneesh Kumar Dwivedi wrote:
[..]
> > > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> > > index 893f953ea..f137f34 100644
> > > --- a/drivers/firmware/qcom_scm.c
> > > +++ b/drivers/firmware/qcom_scm.c
> > > @@ -42,6 +42,18 @@ struct qcom_scm {
> > > static struct qcom_scm *__scm;
> > > +struct dest_vm_and_perm_info {
> > > + __le32 vm;
> > > + __le32 perm;
> > > + __le32 *ctx;
> > Drop the pointer? Just treat it like another number? Pointer is
> > really odd because it doesn't really make any sense what the
> > address of the pointer would be.
> Downstream this is pointer though unused, that is why kept same will check
> and change.
The problem is that the size of a pointer depends on which platform
you're on. Spelling out __le32 here is then just deceiving.
> >
> > > + __le32 ctx_size;
> > > +};
[..]
> > > +int qcom_scm_assign_mem(struct vmid_detail vmid)
[..]
> > > + ret = __qcom_scm_assign_mem(__scm->dev, vmid);
> > > + if (!ret)
> > > + goto free_fw_buff;
> > > + return ret;
> > We don't free dma on failure?
> Did not get, isnt i am freeing all dma allocs on failure?
In the event that __qcom_scm_assign_mem() returns non-zero your not
jumping to free_fw_buff and just returning "ret" without freeing
the memory.
[..]
> > > diff --git a/drivers/firmware/qcom_scm.h b/drivers/firmware/qcom_scm.h
> > > index 3584b00..4665a11 100644
> > > --- a/drivers/firmware/qcom_scm.h
> > > +++ b/drivers/firmware/qcom_scm.h
> > > @@ -55,6 +55,9 @@ extern int __qcom_scm_pas_mem_setup(struct device *dev, u32 peripheral,
> > > extern int __qcom_scm_pas_auth_and_reset(struct device *dev, u32 peripheral);
> > > extern int __qcom_scm_pas_shutdown(struct device *dev, u32 peripheral);
> > > extern int __qcom_scm_pas_mss_reset(struct device *dev, bool reset);
> > > +#define QCOM_SCM_SVC_MP 0xc
> > This is already defined upstream?
> Will check, but i thought its not there.
We use the qcom_scm-api to abstract these facts, so this is an internal
constant - as such it goes in drivers/firmware/qcom_scm.h - and it's
already defined.
Regards,
Bjorn
next prev parent reply other threads:[~2017-04-14 17:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 18:03 [PATCH v3 0/2] Enable mss rproc support on msm8996 Avaneesh Kumar Dwivedi
2017-03-08 18:03 ` [PATCH v3 1/2] soc: qcom: Add support of scm call for mss rproc to share access of ddr Avaneesh Kumar Dwivedi
2017-04-05 23:44 ` Stephen Boyd
2017-04-14 14:01 ` Dwivedi, Avaneesh Kumar (avani)
2017-04-14 17:59 ` Bjorn Andersson [this message]
2017-04-06 4:43 ` Bjorn Andersson
2017-04-14 13:54 ` Dwivedi, Avaneesh Kumar (avani)
2017-04-14 16:46 ` Bjorn Andersson
2017-03-08 18:03 ` [PATCH v3 2/2] remoteproc: qcom: Enable mss rproc support on msm8996 Avaneesh Kumar Dwivedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170414175924.GS70446@Bjorns-MacBook-Pro-2.local \
--to=bjorn.andersson@linaro.org \
--cc=agross@codeaurora.org \
--cc=akdwived@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).