From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: fenglinw-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Richard Purdie <rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org>,
Jacek Anaszewski
<jacek.anaszewski-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
subbaram-jfJNa2p1gH1BDgjK7y7TUQ@public.gmane.org,
aghayal-Rm6X0d1/PG5y9aJCnZT0Uw@public.gmane.org,
wruan-jfJNa2p1gH1BDgjK7y7TUQ@public.gmane.org,
kgunda-Rm6X0d1/PG5y9aJCnZT0Uw@public.gmane.org
Subject: Re: [PATCH V2 1/2] leds: leds-qti-rgb: Add LED driver for QTI TRI_LED module
Date: Wed, 7 Jun 2017 17:08:17 -0500 [thread overview]
Message-ID: <20170607220817.psmcljxaqlwrqxnm@rob-hp-laptop> (raw)
In-Reply-To: <20170601072723.12760-1-fenglinw-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
On Thu, Jun 01, 2017 at 03:25:01PM +0800, fenglinw-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org wrote:
> From: Fenglin Wu <fenglinw-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
>
> QTI TRI_LED module has 3 current sinks for LED driver and each is
> controlled by a PWM channel used for LED dimming or blinking. Add
> the driver to support it.
>
> Signed-off-by: Fenglin Wu <fenglinw-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> ---
> .../devicetree/bindings/leds/leds-qti-rgb.txt | 46 ++
It's preferred to make bindings a separate patch.
> drivers/leds/Kconfig | 8 +
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-qti-rgb.c | 623 +++++++++++++++++++++
> 4 files changed, 678 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/leds-qti-rgb.txt
> create mode 100644 drivers/leds/leds-qti-rgb.c
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-qti-rgb.txt b/Documentation/devicetree/bindings/leds/leds-qti-rgb.txt
> new file mode 100644
> index 0000000..2ca93f9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-qti-rgb.txt
> @@ -0,0 +1,46 @@
> +Qualcomm Technologies, Inc. TRI_LED driver specific bindings
> +
> +This binding document describes the properties of TRI_LED module in
> +Qualcomm Technologies, Inc. PMIC chips.
> +
> +- compatible:
> + Usage: required
> + Value type: <string>
> + Definition: Must be "qcom,leds-rgb".
If the block is called TRI_LED, then use "tri-led" in the name.
> +
> +- reg:
> + Usage: required
> + Value type: <prop-encoded-array>
> + Definition: Register base of the TRI_LED module and length.
> +
> +- pwm-names:
> + Usage: required
> + Value type: <stringlist>
> + Definition: A list of string to label the PWM devices defined in pwms
> + property which are using for controlling LEDs.
> + It must be: "red", "green", "blue".
> +
> +- pwms:
> + Usage: required
> + Value type: <prop-encoded-array>
> + Definition: A list of the PWM devices (phandles) used for controlling
> + LEDs.
> +
> +- qcom,support-blink:
> + Usage: optional
> + Value type: <prop-encoded-array>
> + Definition: An array of integer values to indicate if "red", "green",
> + "blue" LED support blink control. The values are listed as
> + the fixed order for "red", "green", "blue" LED.
> +
> +Example:
> +
> + pmi8998_rgb: rgb@d000{
Need to state somewhere this must be a sub-node of the PMIC and show
that here.
Also, need a space before {.
> + compatible = "qcom,leds-rgb";
> + reg = <0xd000 0x100>;
> + pwm-names = "red", "green", "blue";
> + pwms = <&pmi8998_pwm_5 0 1000000>,
> + <&pmi8998_pwm_4 0 1000000>,
> + <&pmi8998_pwm_3 0 1000000>;
> + qcom,support-blink = <1 1 1>;
> + };
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-06-07 22:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 7:25 [PATCH V2 1/2] leds: leds-qti-rgb: Add LED driver for QTI TRI_LED module fenglinw
2017-06-04 18:33 ` Jacek Anaszewski
[not found] ` <8058ed85-5a64-8dc3-99ea-1ad8128e043d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-06-05 21:16 ` Pavel Machek
2017-06-06 20:07 ` Jacek Anaszewski
2017-06-06 20:13 ` Pavel Machek
[not found] ` <20170601072723.12760-1-fenglinw-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-06-07 22:08 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607220817.psmcljxaqlwrqxnm@rob-hp-laptop \
--to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=aghayal-Rm6X0d1/PG5y9aJCnZT0Uw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=fenglinw-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=jacek.anaszewski-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=kgunda-Rm6X0d1/PG5y9aJCnZT0Uw@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pavel-+ZI9xUNit7I@public.gmane.org \
--cc=rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org \
--cc=subbaram-jfJNa2p1gH1BDgjK7y7TUQ@public.gmane.org \
--cc=wruan-jfJNa2p1gH1BDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).