From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sean Paul <seanpaul@chromium.org>
Subject: Re: [DPU PATCH v2 12/12] drm/msm/dpu: add error handling in
 dpu_core_perf_crtc_update
Date: Fri, 11 May 2018 11:49:31 -0400
Message-ID: <20180511154931.GX33053@art_vandelay>
References: <1526050178-31893-1-git-send-email-ryadav@codeaurora.org>
 <1526050178-31893-13-git-send-email-ryadav@codeaurora.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <1526050178-31893-13-git-send-email-ryadav@codeaurora.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Rajesh Yadav <ryadav@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, hoegsberg@chromium.org, freedreno@lists.freedesktop.org
List-Id: linux-arm-msm@vger.kernel.org

T24gRnJpLCBNYXkgMTEsIDIwMTggYXQgMDg6MTk6MzhQTSArMDUzMCwgUmFqZXNoIFlhZGF2IHdy
b3RlOgo+IGRwdV9jb3JlX3BlcmZfY3J0Y191cGRhdGUoKSBpcyByZXNwb25zaWJsZSBmb3IgYWdn
cmVnYXRpbmcKPiB0aGUgZGF0YSBidXMgYmFuZHdpZHRoIGFuZCBkcHUgY29yZSBjbG9jayByYXRl
IHJlcXVpcmVtZW50cwo+IGFuZCByZXF1ZXN0IHRoZSBzYW1lIGZvciBhbGwgYWN0aXZlIGNydGNz
Lgo+IEN1cnJlbnRseSwgdGhlcmUgaXMgbm8gZXJyb3IgaGFuZGxpbmcgc3VwcG9ydCBpbiB0aGlz
IGZ1bmN0aW9uCj4gc28gdGhlcmUgaXMgbm8gd2F5IGNhbGxlciBjYW4ga25vdyBpZiB0aGUgcGVy
ZiByZXF1ZXN0IGZhaWxzLgo+IFRoaXMgY2hhbmdlIGFkZHMgZXJyb3IgaGFuZGxpbmcgY29kZSBp
biBkcHVfY29yZV9wZXJmX2NydGNfdXBkYXRlKCkuCj4gVGhlIGNhbGxlciBzaWRlIGVycm9yIGhh
bmRsaW5nIGlzIG5vdCBhZGRlZCBpbiB0aGlzIHBhdGNoLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFJh
amVzaCBZYWRhdiA8cnlhZGF2QGNvZGVhdXJvcmEub3JnPgoKQ29vbCEgVGhhbmtzIGZvciBkb2lu
ZyB0aGlzIDotKQoKUmV2aWV3ZWQtYnk6IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3Jn
PgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2NvcmVfcGVyZi5j
IHwgMzcgKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20v
ZGlzcC9kcHUxL2RwdV9jb3JlX3BlcmYuaCB8ICAzICsrLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDI3
IGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz
L2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfY29yZV9wZXJmLmMgYi9kcml2ZXJzL2dwdS9kcm0v
bXNtL2Rpc3AvZHB1MS9kcHVfY29yZV9wZXJmLmMKPiBpbmRleCBkM2ExZWQ5Li44NWMwMjI5IDEw
MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9jb3JlX3BlcmYu
Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9jb3JlX3BlcmYuYwo+
IEBAIC0yNDgsNyArMjQ4LDcgQEAgaW50IGRwdV9jb3JlX3BlcmZfY3J0Y19jaGVjayhzdHJ1Y3Qg
ZHJtX2NydGMgKmNydGMsCj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAKPiAtc3RhdGljIHZvaWQgX2Rw
dV9jb3JlX3BlcmZfY3J0Y191cGRhdGVfYnVzKHN0cnVjdCBkcHVfa21zICprbXMsCj4gK3N0YXRp
YyBpbnQgX2RwdV9jb3JlX3BlcmZfY3J0Y191cGRhdGVfYnVzKHN0cnVjdCBkcHVfa21zICprbXMs
Cj4gIAkJc3RydWN0IGRybV9jcnRjICpjcnRjLCB1MzIgYnVzX2lkKQo+ICB7Cj4gIAl1NjQgYndf
c3VtX29mX2ludGZzID0gMCwgYnVzX2FiX3F1b3RhLCBidXNfaWJfcXVvdGE7Cj4gQEAgLTI1Nyw2
ICsyNTcsNyBAQCBzdGF0aWMgdm9pZCBfZHB1X2NvcmVfcGVyZl9jcnRjX3VwZGF0ZV9idXMoc3Ry
dWN0IGRwdV9rbXMgKmttcywKPiAgCQkJCQk9IGRwdV9jcnRjX2dldF9jbGllbnRfdHlwZShjcnRj
KTsKPiAgCXN0cnVjdCBkcm1fY3J0YyAqdG1wX2NydGM7Cj4gIAlzdHJ1Y3QgZHB1X2NydGNfc3Rh
dGUgKmRwdV9jc3RhdGU7Cj4gKwlpbnQgcmV0ID0gMDsKPiAgCj4gIAlkcm1fZm9yX2VhY2hfY3J0
Yyh0bXBfY3J0YywgY3J0Yy0+ZGV2KSB7Cj4gIAkJaWYgKF9kcHVfY29yZV9wZXJmX2NydGNfaXNf
cG93ZXJfb24odG1wX2NydGMpICYmCj4gQEAgLTI4NiwyNSArMjg3LDI4IEBAIHN0YXRpYyB2b2lk
IF9kcHVfY29yZV9wZXJmX2NydGNfdXBkYXRlX2J1cyhzdHJ1Y3QgZHB1X2ttcyAqa21zLAo+ICAK
PiAgCXN3aXRjaCAoY3Vycl9jbGllbnRfdHlwZSkgewo+ICAJY2FzZSBOUlRfQ0xJRU5UOgo+IC0J
CWRwdV9wb3dlcl9kYXRhX2J1c19zZXRfcXVvdGEoJmttcy0+cGhhbmRsZSwga21zLT5jb3JlX2Ns
aWVudCwKPiArCQlyZXQgPSBkcHVfcG93ZXJfZGF0YV9idXNfc2V0X3F1b3RhKAo+ICsJCQkJJmtt
cy0+cGhhbmRsZSwga21zLT5jb3JlX2NsaWVudCwKPiAgCQkJCURQVV9QT1dFUl9IQU5ETEVfREFU
QV9CVVNfQ0xJRU5UX05SVCwKPiAgCQkJCWJ1c19pZCwgYnVzX2FiX3F1b3RhLCBidXNfaWJfcXVv
dGEpOwo+ICAJCURQVV9ERUJVRygiY2xpZW50OiVzIGJ1c19pZD0lZCBhYj0lbGx1IGliPSVsbHVc
biIsICJucnQiLAo+IC0JCQkJYnVzX2lkLCBidXNfYWJfcXVvdGEsIGJ1c19pYl9xdW90YSk7Cj4g
KwkJCSAgYnVzX2lkLCBidXNfYWJfcXVvdGEsIGJ1c19pYl9xdW90YSk7Cj4gIAkJYnJlYWs7Cj4g
IAo+ICAJY2FzZSBSVF9DTElFTlQ6Cj4gLQkJZHB1X3Bvd2VyX2RhdGFfYnVzX3NldF9xdW90YSgm
a21zLT5waGFuZGxlLCBrbXMtPmNvcmVfY2xpZW50LAo+ICsJCXJldCA9IGRwdV9wb3dlcl9kYXRh
X2J1c19zZXRfcXVvdGEoCj4gKwkJCQkma21zLT5waGFuZGxlLCBrbXMtPmNvcmVfY2xpZW50LAo+
ICAJCQkJRFBVX1BPV0VSX0hBTkRMRV9EQVRBX0JVU19DTElFTlRfUlQsCj4gIAkJCQlidXNfaWQs
IGJ1c19hYl9xdW90YSwgYnVzX2liX3F1b3RhKTsKPiAgCQlEUFVfREVCVUcoImNsaWVudDolcyBi
dXNfaWQ9JWQgYWI9JWxsdSBpYj0lbGx1XG4iLCAicnQiLAo+IC0JCQkJYnVzX2lkLCBidXNfYWJf
cXVvdGEsIGJ1c19pYl9xdW90YSk7Cj4gKwkJCSAgYnVzX2lkLCBidXNfYWJfcXVvdGEsIGJ1c19p
Yl9xdW90YSk7Cj4gIAkJYnJlYWs7Cj4gIAo+ICAJZGVmYXVsdDoKPiAgCQlEUFVfRVJST1IoImlu
dmFsaWQgY2xpZW50IHR5cGU6JWRcbiIsIGN1cnJfY2xpZW50X3R5cGUpOwo+ICAJCWJyZWFrOwo+
ICAJfQo+ICsJcmV0dXJuIHJldDsKPiAgfQo+ICAKPiAgLyoqCj4gQEAgLTM5OSw3ICs0MDMsNyBA
QCBzdGF0aWMgdTY0IF9kcHVfY29yZV9wZXJmX2dldF9jb3JlX2Nsa19yYXRlKHN0cnVjdCBkcHVf
a21zICprbXMpCj4gIAlyZXR1cm4gY2xrX3JhdGU7Cj4gIH0KPiAgCj4gLXZvaWQgZHB1X2NvcmVf
cGVyZl9jcnRjX3VwZGF0ZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gK2ludCBkcHVfY29yZV9w
ZXJmX2NydGNfdXBkYXRlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCQlpbnQgcGFyYW1zX2No
YW5nZWQsIGJvb2wgc3RvcF9yZXEpCj4gIHsKPiAgCXN0cnVjdCBkcHVfY29yZV9wZXJmX3BhcmFt
cyAqbmV3LCAqb2xkOwo+IEBAIC00MTAsMTYgKzQxNCwxNyBAQCB2b2lkIGRwdV9jb3JlX3BlcmZf
Y3J0Y191cGRhdGUoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJaW50IGk7Cj4gIAlzdHJ1Y3Qg
bXNtX2RybV9wcml2YXRlICpwcml2Owo+ICAJc3RydWN0IGRwdV9rbXMgKmttczsKPiArCWludCBy
ZXQ7Cj4gIAo+ICAJaWYgKCFjcnRjKSB7Cj4gIAkJRFBVX0VSUk9SKCJpbnZhbGlkIGNydGNcbiIp
Owo+IC0JCXJldHVybjsKPiArCQlyZXR1cm4gLUVJTlZBTDsKPiAgCX0KPiAgCj4gIAlrbXMgPSBf
ZHB1X2NydGNfZ2V0X2ttcyhjcnRjKTsKPiAgCWlmICgha21zIHx8ICFrbXMtPmNhdGFsb2cpIHsK
PiAgCQlEUFVfRVJST1IoImludmFsaWQga21zXG4iKTsKPiAtCQlyZXR1cm47Cj4gKwkJcmV0dXJu
IC1FSU5WQUw7Cj4gIAl9Cj4gIAlwcml2ID0ga21zLT5kZXYtPmRldl9wcml2YXRlOwo+ICAKPiBA
QCAtNDgyLDggKzQ4NywxNCBAQCB2b2lkIGRwdV9jb3JlX3BlcmZfY3J0Y191cGRhdGUoc3RydWN0
IGRybV9jcnRjICpjcnRjLAo+ICAJCQkJdXBkYXRlX2J1cywgdXBkYXRlX2Nsayk7Cj4gIAo+ICAJ
Zm9yIChpID0gMDsgaSA8IERQVV9QT1dFUl9IQU5ETEVfREJVU19JRF9NQVg7IGkrKykgewo+IC0J
CWlmICh1cGRhdGVfYnVzICYgQklUKGkpKQo+IC0JCQlfZHB1X2NvcmVfcGVyZl9jcnRjX3VwZGF0
ZV9idXMoa21zLCBjcnRjLCBpKTsKPiArCQlpZiAodXBkYXRlX2J1cyAmIEJJVChpKSkgewo+ICsJ
CQlyZXQgPSBfZHB1X2NvcmVfcGVyZl9jcnRjX3VwZGF0ZV9idXMoa21zLCBjcnRjLCBpKTsKPiAr
CQkJaWYgKHJldCkgewo+ICsJCQkJRFBVX0VSUk9SKCJjcnRjLSVkOiBmYWlsZWQgdG8gdXBkYXRl
IGJ3IHZvdGUgZm9yIGJ1cy0lZFxuIiwKPiArCQkJCQkgIGNydGMtPmJhc2UuaWQsIGkpOwo+ICsJ
CQkJcmV0dXJuIHJldDsKPiArCQkJfQo+ICsJCX0KPiAgCX0KPiAgCj4gIAkvKgo+IEBAIC00OTUs
MTUgKzUwNiwxNyBAQCB2b2lkIGRwdV9jb3JlX3BlcmZfY3J0Y191cGRhdGUoc3RydWN0IGRybV9j
cnRjICpjcnRjLAo+ICAKPiAgCQlEUFVfRVZUMzIoa21zLT5kZXYsIHN0b3BfcmVxLCBjbGtfcmF0
ZSk7Cj4gIAo+IC0JCWlmIChfZHB1X2NvcmVfcGVyZl9zZXRfY29yZV9jbGtfcmF0ZShrbXMsIGNs
a19yYXRlKSkgewo+ICsJCXJldCA9IF9kcHVfY29yZV9wZXJmX3NldF9jb3JlX2Nsa19yYXRlKGtt
cywgY2xrX3JhdGUpOwo+ICsJCWlmIChyZXQpIHsKPiAgCQkJRFBVX0VSUk9SKCJmYWlsZWQgdG8g
c2V0ICVzIGNsb2NrIHJhdGUgJWxsdVxuIiwKPiAgCQkJCQlrbXMtPnBlcmYuY29yZV9jbGstPmNs
a19uYW1lLCBjbGtfcmF0ZSk7Cj4gLQkJCXJldHVybjsKPiArCQkJcmV0dXJuIHJldDsKPiAgCQl9
Cj4gIAo+ICAJCWttcy0+cGVyZi5jb3JlX2Nsa19yYXRlID0gY2xrX3JhdGU7Cj4gIAkJRFBVX0RF
QlVHKCJ1cGRhdGUgY2xrIHJhdGUgPSAlbGxkIEhaXG4iLCBjbGtfcmF0ZSk7Cj4gIAl9Cj4gKwly
ZXR1cm4gMDsKPiAgfQo+ICAKPiAgI2lmZGVmIENPTkZJR19ERUJVR19GUwo+IGRpZmYgLS1naXQg
YS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfY29yZV9wZXJmLmggYi9kcml2ZXJz
L2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfY29yZV9wZXJmLmgKPiBpbmRleCBjZGU0OGRmLi40
NDBkNmEyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9j
b3JlX3BlcmYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9jb3Jl
X3BlcmYuaAo+IEBAIC05MSw4ICs5MSw5IEBAIGludCBkcHVfY29yZV9wZXJmX2NydGNfY2hlY2so
c3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAgKiBAY3J0YzogUG9pbnRlciB0byBjcnRjCj4gICAq
IEBwYXJhbXNfY2hhbmdlZDogdHJ1ZSBpZiBjcnRjIHBhcmFtZXRlcnMgYXJlIG1vZGlmaWVkCj4g
ICAqIEBzdG9wX3JlcTogdHJ1ZSBpZiB0aGlzIGlzIGEgc3RvcCByZXF1ZXN0Cj4gKyAqIHJldHVy
bjogemVybyBpZiBzdWNjZXNzLCBvciBlcnJvciBjb2RlIG90aGVyd2lzZQo+ICAgKi8KPiAtdm9p
ZCBkcHVfY29yZV9wZXJmX2NydGNfdXBkYXRlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAraW50
IGRwdV9jb3JlX3BlcmZfY3J0Y191cGRhdGUoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJCWlu
dCBwYXJhbXNfY2hhbmdlZCwgYm9vbCBzdG9wX3JlcSk7Cj4gIAo+ICAvKioKPiAtLSAKPiBUaGUg
UXVhbGNvbW0gSW5ub3ZhdGlvbiBDZW50ZXIsIEluYy4gaXMgYSBtZW1iZXIgb2YgdGhlIENvZGUg
QXVyb3JhIEZvcnVtLAo+IGEgTGludXggRm91bmRhdGlvbiBDb2xsYWJvcmF0aXZlIFByb2plY3QK
PiAKCi0tIApTZWFuIFBhdWwsIFNvZnR3YXJlIEVuZ2luZWVyLCBHb29nbGUgLyBDaHJvbWl1bSBP
UwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2
ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s
aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK