From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH v3 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings Date: Wed, 30 May 2018 16:48:49 +0100 Message-ID: <20180530154849.GQ6920@sirena.org.uk> References: <20180523082908.GB4828@sirena.org.uk> <20180523154057.GL4828@sirena.org.uk> <20180523155617.GN4828@sirena.org.uk> <20180530093701.GD6920@sirena.org.uk> <20180530150241.GO6920@sirena.org.uk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vIXBmblrD40XNCy4" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Doug Anderson Cc: David Collins , Liam Girdwood , Rob Herring , Mark Rutland , linux-arm-msm@vger.kernel.org, Linux ARM , devicetree@vger.kernel.org, LKML , Rajendra Nayak , Stephen Boyd List-Id: linux-arm-msm@vger.kernel.org --vIXBmblrD40XNCy4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 30, 2018 at 08:34:50AM -0700, Doug Anderson wrote: > On Wed, May 30, 2018 at 8:02 AM, Mark Brown wrote: > > What you're describing sounds like what we should be doing normally, if > > we're not doing that we should probably be fixing the core. > I'm not convinced that this behavior makes sense to move to the core. > On most regulators I'd expect that when the regulator driver says to > turn them off that they will output no voltage. The reason RPMh is Oh, you mean while the regulator is off... TBH I don't see a huge problem doing that anyway and just reverting to the bottom of the constraints when everything gets turned off since we have to see if we need to adjust the voltage every time we enabled anyway. > In any other system when Linux disabled the regulator it wouldn't > matter that you left it set at 1.4V. Thus RPMh is special and IMO the > workaround belongs there. Without the core doing something the regulator isn't going to get told that anything updated voltages anyway... --vIXBmblrD40XNCy4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlsOx+AACgkQJNaLcl1U h9DtYAf/d42wzL/BwC0ZoU87rcBj1tg5JnI3JXmEjk0TAEr8Mr9X26kTgvNDN4he sfj0TCQnt106iCytS9vuq13r0vc0N8a73zACI9rBL4AFN2r8/KqyjfG5iuD1IYUf eEAlJeBHT5jL8EJOiBgq2z+8n4jIPNnZdK/A8kanILTb2D0yU9LmqXJaLCquSBef d3otBG5MHDZNmBvemCG07/dvdvwHHmOZu/QAEsxkqP6cuqw+phTpVrIc2+40lHJk QfVj28IYFDxNf3viq4W606P0LE0BtP3pwjhFyKUj6CdLFzFli+EI7lXBuvp1q3UB eEWC9xQb5Fw2b4Hj5h+RS6hFhej0mw== =hSKi -----END PGP SIGNATURE----- --vIXBmblrD40XNCy4--