From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH v3 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings Date: Wed, 30 May 2018 17:36:44 +0100 Message-ID: <20180530163644.GW6920@sirena.org.uk> References: <20180530093701.GD6920@sirena.org.uk> <20180530150241.GO6920@sirena.org.uk> <20180530154849.GQ6920@sirena.org.uk> <20180530160744.GS6920@sirena.org.uk> <20180530161311.GT6920@sirena.org.uk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aXNiKu4lnbRqA5kZ" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Doug Anderson Cc: David Collins , Liam Girdwood , Rob Herring , Mark Rutland , linux-arm-msm@vger.kernel.org, Linux ARM , devicetree@vger.kernel.org, LKML , Rajendra Nayak , Stephen Boyd List-Id: linux-arm-msm@vger.kernel.org --aXNiKu4lnbRqA5kZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 30, 2018 at 09:31:55AM -0700, Doug Anderson wrote: > On Wed, May 30, 2018 at 9:13 AM, Mark Brown wrote: > > If we're just going to use the most recently set voltage then hopefully > > the hardware already knew that, and it might not be the lowest available > > voltage if the last consumer to get turned off was holding the voltage > > higher. > To circle back to the original point: the problem is that (IMHO) the > hardware is doing the wrong thing by still counting Linux's vote for a > voltage even though Linux also voted that the regulator should be > disabled. So basically we're working around the hardware by > pretending to vote for a dummy lower voltage whenever Linux wants the > regulator disabled. From Linux's point of view everything works as > normal--we just tell the hardware a falsehood so it doesn't count our > vote for a voltage while the regulator is disabled. Yeah, and I don't think that's unreasonable for the core to do - just drop the voltage to the constraint minimum after it has turned off the regulator, then recheck and raise if needed before it enables again. --aXNiKu4lnbRqA5kZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlsO0xsACgkQJNaLcl1U h9Agtwf+I81NatfMRn647f4v1D+5TzY5LKIT63m6HP7ZlC6S1WdaLKEZ+TU2wnWk fcuCPLxowzFTwBRLgI3yg258uT9eir/f5m0jteKact4i3o4uAzpzXtgb6pMMvnug k16LIeX2My8QeeJFSaKOH9UPhlavA4JI9gZo+yNje3b7oO0fuTlcJcQp7QSWfCAn aEcEO/oovw6qrNyG9+U01J3fjkMtWvAAaX75tErSeswLFw5OAzyM6qrRfzwDHHgN ySW29niz7c/X5Vqi+FUcRG8IBeBNJwzQdXhRvYH6chiiwmrhcVgIgw9ztMu/bXas 1V5YuFilrVaenIaenzesMJ9l3r5KRg== =KkMi -----END PGP SIGNATURE----- --aXNiKu4lnbRqA5kZ--