From: Sam Ravnborg <sam@ravnborg.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
nouveau@lists.freedesktop.org, Liviu Dudau <liviu.dudau@arm.com>,
DRI Development <dri-devel@lists.freedesktop.org>,
virtualization@lists.linux-foundation.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Daniel Vetter <daniel.vetter@intel.com>,
linux-stm32@st-md-mailman.stormreply.com,
linux-samsung-soc@vger.kernel.org,
Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
amd-gfx@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
spice-devel@lists.freedesktop.org,
Jani Nikula <jani.nikula@intel.com>,
linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
etnaviv@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, xen-devel@lists.xen.org,
linux-renesa
Subject: Re: [PATCH] drm: Split out drm_probe_helper.h
Date: Wed, 16 Jan 2019 19:10:18 +0100 [thread overview]
Message-ID: <20190116181018.GA27364@ravnborg.org> (raw)
In-Reply-To: <20190116163442.12622-1-daniel.vetter@ffwll.ch>
Hi Daniel.
> v5: Actually try to sort them, and while at it, sort all the ones I
> touch.
Applied this variant on top of drm-misc and did a build test.
Looked good for ia64, x86 and alpha.
Took a closer look at the changes to atmel_hlcd - and they looked OK.
But I noticed that atmel_hlcdc uses only drm_kms_helper_poll_init() and
drm_kms_helper_poll_fini().
But there are no hits on DRM_CONNECTOR_POLL - so I think we maybe
have a driver here where we have plugged the drm_poll infrastructure,
but it is not in use.
> include/drm/drm_crtc_helper.h | 16 -----------
The list of include files in this file could be dropped and replaced by:
struct drm_connector;
struct drm_device;
struct drm_display_mode;
struct drm_encoder;
struct drm_framebuffer;
struct drm_mode_set;
struct drm_modeset_acquire_ctx;
I tried to do so on top of your patch.
But there were too many build errros and I somehow lost the motivation.
> include/drm/drm_probe_helper.h | 27 +++++++++++++++++++
This on the other hand is fine - as expected as this is a new file.
But the above is just some random comments so:
Acked-by: Sam Ravnborg <sam@ravnborg.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-01-16 18:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 16:34 [PATCH] drm: Split out drm_probe_helper.h Daniel Vetter
2019-01-16 18:10 ` Sam Ravnborg [this message]
[not found] ` <20190116181018.GA27364-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
2019-01-17 16:45 ` Daniel Vetter
2019-01-17 17:45 ` Sam Ravnborg
2019-01-21 22:13 ` Sam Ravnborg
[not found] ` <20190121221329.GA6512-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
2019-01-22 8:03 ` Daniel Vetter
2019-01-17 21:03 ` Daniel Vetter
2019-01-22 21:16 ` Wentland, Harry
[not found] ` <20190117210334.13234-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2019-01-23 17:00 ` Sam Ravnborg
2019-01-24 9:46 ` Daniel Vetter
[not found] ` <20190124094646.GR3271-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2019-01-24 12:39 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2019-01-16 13:51 Daniel Vetter
2019-01-15 10:41 Daniel Vetter
[not found] ` <20190115104137.25695-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2019-01-15 10:57 ` Jani Nikula
2019-01-15 12:26 ` Neil Armstrong
2019-01-15 14:58 ` Oleksandr Andrushchenko
2019-01-16 3:30 ` Alex Deucher
2019-01-15 14:30 ` Laurent Pinchart
2019-01-16 2:11 ` CK Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116181018.GA27364@ravnborg.org \
--to=sam@ravnborg.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-tegra@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=narmstrong@baylibre.com \
--cc=nouveau@lists.freedesktop.org \
--cc=oleksandr_andrushchenko@epam.com \
--cc=rodrigo.vivi@intel.com \
--cc=spice-devel@lists.freedesktop.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).