linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Stephen Boyd <swboyd@chromium.org>, Rob Herring <robh@kernel.org>,
	Alexander Graf <agraf@suse.de>
Cc: Rajendra Nayak <rnayak@codeaurora.org>,
	andy.gross@linaro.org, david.brown@linaro.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux@roeck-us.net
Subject: Re: [PATCH] soc: qcom: update config dependencies for QCOM_RPMPD
Date: Wed, 30 Jan 2019 17:32:44 -0800	[thread overview]
Message-ID: <20190131013244.GC27190@builder> (raw)
In-Reply-To: <154783318835.169631.6614930101893188915@swboyd.mtv.corp.google.com>

On Fri 18 Jan 09:39 PST 2019, Stephen Boyd wrote:

> Quoting Rajendra Nayak (2019-01-17 20:48:01)
> >  drivers/soc/qcom/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> > index a5d5167c3f16..1ee298f6bf17 100644
> > --- a/drivers/soc/qcom/Kconfig
> > +++ b/drivers/soc/qcom/Kconfig
> > @@ -109,7 +109,7 @@ config QCOM_RPMHPD
> >  
> >  config QCOM_RPMPD
> >         bool "Qualcomm RPM Power domain driver"
> 
> Just curious, does it need to be bool for some reason?
> 

It's unfortunately not possible to have any genpd, iommu or pinctrl
drivers compiled as modules, because once you pass lateinit probe
deferral is purposefully broken. See
driver_deferred_probe_check_state().

This also means that if you're unlucky and your kernel reached lateinit
before the SMD communication with RPM is established and has brought up
the rpmpd, you are left with a completely broken system. Unfortunately
this isn't that hard to reproduce with a minimal defconfig.

Regards,
Bjorn

      parent reply	other threads:[~2019-01-31  1:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-18  4:48 [PATCH] soc: qcom: update config dependencies for QCOM_RPMPD Rajendra Nayak
2019-01-18 17:39 ` Stephen Boyd
2019-01-22  2:30   ` Rajendra Nayak
2019-01-22  5:08     ` Guenter Roeck
2019-01-22  9:54       ` Rajendra Nayak
2019-01-22 10:08         ` Viresh Kumar
2019-01-22 10:35           ` Rajendra Nayak
2019-01-23 11:16             ` Viresh Kumar
2019-01-23 14:22               ` Guenter Roeck
2019-01-24  6:45                 ` Viresh Kumar
2019-01-31  1:32   ` Bjorn Andersson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190131013244.GC27190@builder \
    --to=bjorn.andersson@linaro.org \
    --cc=agraf@suse.de \
    --cc=andy.gross@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=rnayak@codeaurora.org \
    --cc=robh@kernel.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).