From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Niklas Cassel <niklas.cassel@linaro.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: qcom: ipq4019: Fix MSI IRQ type
Date: Tue, 5 Feb 2019 10:13:26 -0800 [thread overview]
Message-ID: <20190205181326.GA23363@builder> (raw)
In-Reply-To: <20190124130047.8071-1-niklas.cassel@linaro.org>
On Thu 24 Jan 05:00 PST 2019, Niklas Cassel wrote:
> The databook clearly states that the MSI IRQ (msi_ctrl_int) is a level
> triggered interrupt.
>
> The msi_ctrl_int will be high for as long as any MSI status bit is set,
> thus the IRQ type should be set to IRQ_TYPE_LEVEL_HIGH, causing the
> IRQ handler to keep getting called, as long as any MSI status bit is set.
>
> A git grep shows that ipq4019 is the only SoC using snps,dw-pcie that has
> configured this IRQ incorrectly.
>
> Not having the correct IRQ type defined will cause us to lose interrupts,
> which in turn causes timeouts in the PCIe endpoint drivers.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Cc: stable@vger.kernel.org
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> arch/arm/boot/dts/qcom-ipq4019.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom-ipq4019.dtsi
> index 19635f91e2c4..48b3cb474ba0 100644
> --- a/arch/arm/boot/dts/qcom-ipq4019.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq4019.dtsi
> @@ -398,7 +398,7 @@
> ranges = <0x81000000 0 0x40200000 0x40200000 0 0x00100000
> 0x82000000 0 0x40300000 0x40300000 0 0x400000>;
>
> - interrupts = <GIC_SPI 141 IRQ_TYPE_EDGE_RISING>;
> + interrupts = <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-names = "msi";
> #interrupt-cells = <1>;
> interrupt-map-mask = <0 0 0 0x7>;
> --
> 2.20.1
>
prev parent reply other threads:[~2019-02-05 18:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 13:00 [PATCH] ARM: dts: qcom: ipq4019: Fix MSI IRQ type Niklas Cassel
2019-02-05 18:13 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190205181326.GA23363@builder \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=niklas.cassel@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).