From: Sean Paul <sean@poorly.run> To: Rob Clark <robdclark@gmail.com> Cc: dri-devel@lists.freedesktop.org, Georgi Djakov <georgi.djakov@linaro.org>, Rob Clark <robdclark@chromium.org>, Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] drm/msm/mdp5: Use the interconnect API Date: Mon, 13 May 2019 10:49:26 -0400 Message-ID: <20190513144926.GQ17077@art_vandelay> (raw) In-Reply-To: <20190508204219.31687-6-robdclark@gmail.com> On Wed, May 08, 2019 at 01:42:15PM -0700, Rob Clark wrote: > From: Georgi Djakov <georgi.djakov@linaro.org> > > Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org> > Signed-off-by: Rob Clark <robdclark@chromium.org> > --- > drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > index 97179bec8902..54d2b4c2b09f 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > @@ -16,6 +16,7 @@ > * this program. If not, see <http://www.gnu.org/licenses/>. > */ > > +#include <linux/interconnect.h> > #include <linux/of_irq.h> > > #include "msm_drv.h" > @@ -1050,6 +1051,19 @@ static const struct component_ops mdp5_ops = { > > static int mdp5_dev_probe(struct platform_device *pdev) > { > + struct icc_path *path0 = of_icc_get(&pdev->dev, "port0"); > + struct icc_path *path1 = of_icc_get(&pdev->dev, "port1"); > + struct icc_path *path_rot = of_icc_get(&pdev->dev, "rotator"); > + > + if (IS_ERR(path0)) Same comments here re: NULL value > + return PTR_ERR(path0); > + icc_set_bw(path0, 0, MBps_to_icc(6400)); > + > + if (!IS_ERR(path1)) > + icc_set_bw(path1, 0, MBps_to_icc(6400)); > + if (!IS_ERR(path_rot)) > + icc_set_bw(path_rot, 0, MBps_to_icc(6400)); > + > DBG(""); > return component_add(&pdev->dev, &mdp5_ops); > } > -- > 2.20.1 > -- Sean Paul, Software Engineer, Google / Chromium OS
next prev parent reply index Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20190508204219.31687-1-robdclark@gmail.com> 2019-05-08 20:42 ` [PATCH 1/5] drm/msm/dpu: clean up references of DPU custom bus scaling Rob Clark 2019-05-13 14:42 ` Sean Paul 2019-05-08 20:42 ` [PATCH 2/5] drm/msm/dpu: Integrate interconnect API in MDSS Rob Clark 2019-05-13 14:47 ` Sean Paul 2019-05-29 13:05 ` Georgi Djakov 2019-05-08 20:42 ` [PATCH 3/5] dt-bindings: msm/disp: Introduce interconnect bindings for MDSS on SDM845 Rob Clark 2019-05-13 14:48 ` Sean Paul 2019-05-08 20:42 ` [PATCH 4/5] drm/msm/dpu: add icc voting in dpu_mdss_init Rob Clark 2019-05-08 20:42 ` [PATCH 5/5] drm/msm/mdp5: Use the interconnect API Rob Clark 2019-05-13 14:49 ` Sean Paul [this message] 2019-05-29 13:08 ` Georgi Djakov 2019-06-18 20:24 [PATCH 0/5] drm/msm: mdp5+dpu interconnect support Rob Clark 2019-06-18 20:24 ` [PATCH 5/5] drm/msm/mdp5: Use the interconnect API Rob Clark
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190513144926.GQ17077@art_vandelay \ --to=sean@poorly.run \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=georgi.djakov@linaro.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robdclark@chromium.org \ --cc=robdclark@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-ARM-MSM Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \ linux-arm-msm@vger.kernel.org public-inbox-index linux-arm-msm Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm AGPL code for this site: git clone https://public-inbox.org/public-inbox.git