From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC8A4C4321A for ; Tue, 11 Jun 2019 18:51:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC35B2177E for ; Tue, 11 Jun 2019 18:51:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560279063; bh=eImiH0U2R9J23GU5acZAV8Hb7EeG17LzFiM7Nb4BDYQ=; h=In-Reply-To:References:To:From:Cc:Subject:Date:List-ID:From; b=NTSl3Rdul/AoFSB+uXW3wPtdgmDgdVjo/ahyhWr76ve+gexDMY6piuXyI9rawYvSv dRz2unoie21y6WkXPGtLQAmCnyQA++U+V18tUlEHhHluRbnxG9Msqn+cUFRIwZl7v8 r3fZz7qzygrJL/mrDqjjmQrswxzhSNTUpZhxdugk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392101AbfFKSvD (ORCPT ); Tue, 11 Jun 2019 14:51:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:33348 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389470AbfFKSvD (ORCPT ); Tue, 11 Jun 2019 14:51:03 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 368ED21744; Tue, 11 Jun 2019 18:51:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560279062; bh=eImiH0U2R9J23GU5acZAV8Hb7EeG17LzFiM7Nb4BDYQ=; h=In-Reply-To:References:To:From:Cc:Subject:Date:From; b=rfzC7eyFSl2rnamYq+e5oFdsnE0+XJDSNRNjSCHAChqv3ZrE2vSQBDpivAVbRv5jP nk5wPdiLmDoMlmcVS0UFYNP3aNmDmtnbm5MYhqojR98C8PmjSZ8VMyuIOEssP+P6ue 63X9EX1KRTWzKQGg4mWfdfH6qE3bgDTOQmIwk69o= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <46b715974766d5c557685a1ab9131abe@codeaurora.org> References: <1559285512-27784-1-git-send-email-tengfeif@codeaurora.org> <20190610145132.DD1132085A@mail.kernel.org> <46b715974766d5c557685a1ab9131abe@codeaurora.org> To: tengfeif@codeaurora.org From: Stephen Boyd Cc: Bjorn Andersson , Linus Walleij , Niklas Cassel , Andy Gross , David Brown , MSM , "open list:GPIO SUBSYSTEM" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: qcom: Clear status bit on irq_unmask User-Agent: alot/0.8.1 Date: Tue, 11 Jun 2019 11:51:01 -0700 Message-Id: <20190611185102.368ED21744@mail.kernel.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting tengfeif@codeaurora.org (2019-06-11 03:41:26) > On 2019-06-10 22:51, Stephen Boyd wrote: > > Quoting Linus Walleij (2019-06-07 14:08:10) > >> On Fri, May 31, 2019 at 8:52 AM Tengfei Fan = > >> wrote: > >>=20 > >> > The gpio interrupt status bit is getting set after the > >> > irq is disabled and causing an immediate interrupt after > >> > enablling the irq, so clear status bit on irq_unmask. > >> > > >> > Signed-off-by: Tengfei Fan > >>=20 > >> This looks pretty serious, can one of the Qcom maintainers ACK > >> this? > >>=20 > >> Should it be sent to fixes and even stable? > >>=20 > >> Fixes: tag? > >>=20 > >=20 > > How is the interrupt status bit getting set after the irq is disabled? > > It looks like this is a level type interrupt? I thought that after > > commit b55326dc969e ("pinctrl: msm: Really mask level interrupts to > > prevent latching") this wouldn't be a problem. Am I wrong, or is qcom > > just clearing out patches on drivers and this is the last one that=20 > > needs > > to be upstreamed? >=20 > Your patch(commit b55326dc969e) can cover our issue, and my patch is no=20 > longer needed. > Your patch isn't included in our code, so I submitted this patch. Alright cool. Sounds like this patch can be dropped then and you can pick up the patch from upstream into your vendor kernel.