From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00ED1C31E4A for ; Thu, 13 Jun 2019 17:10:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C1F35205ED for ; Thu, 13 Jun 2019 17:10:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560445841; bh=z/CM3q0QFgMafRlvcoS3yJRC23xA3AlrEPJbgJvH5jU=; h=In-Reply-To:References:To:From:Cc:Subject:Date:List-ID:From; b=YA2IyOBWsMquZagibQBk4XYFCSpU26BYVRwxuawTEPNJC9p5ZCVmiRMpLW4g+7HZ2 9Nohf8vWvgs/T2f9zBo4XH5F7nEyhPqyE3oFRHqTG6WJfwzisdiZxpumi5HNpkAi31 EQUYzw+xkhbvkdm6vG6oY/TrS6wFZrAHSH5Zc9jA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393539AbfFMRKk (ORCPT ); Thu, 13 Jun 2019 13:10:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:41600 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729338AbfFLWmz (ORCPT ); Wed, 12 Jun 2019 18:42:55 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4E2EA215EA; Wed, 12 Jun 2019 22:42:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560379374; bh=z/CM3q0QFgMafRlvcoS3yJRC23xA3AlrEPJbgJvH5jU=; h=In-Reply-To:References:To:From:Cc:Subject:Date:From; b=it7bebKmAU/aYbWt4bSiJsGg/sdkB5rSyh++hpwiSLWNO4i6j1hMYOfxYp7/GEA4+ h2+nhiwQjFPzHccevwb1HC7ZkmI5eAqJw7haeVx8s/D2dlyC3GCGyuDksWlEerLwhw HWYRn+EMAcof7ivCZNgh8EWiOQedlZRd/8gYbcoU= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <49b95f19-4da6-4491-6ed7-5238ecfc35a8@free.fr> <20190612191347.GE22737@tuxbook-pro> <20190612194915.8F5DD20866@mail.kernel.org> To: Bjorn Andersson , Marc Gonzalez From: Stephen Boyd Cc: Michael Turquette , linux-clk , MSM , Georgi Djakov , Amit Kucheria Subject: Re: [PATCH v1] clk: qcom: msm8916: Don't build support by default User-Agent: alot/0.8.1 Date: Wed, 12 Jun 2019 15:42:53 -0700 Message-Id: <20190612224254.4E2EA215EA@mail.kernel.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Marc Gonzalez (2019-06-12 13:03:22) > On 12/06/2019 21:49, Stephen Boyd wrote: >=20 > > Quoting Bjorn Andersson (2019-06-12 12:13:47) > > > >> On Wed 12 Jun 08:52 PDT 2019, Marc Gonzalez wrote: > >> > >>> Build QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 by default only when > >>> we're building MSM_GCC_8916. > >>> > >>> Signed-off-by: Marc Gonzalez > >> > >> Not sure why these are default at all. > >> > >> But both drivers are used on platforms other than 8916 as well, so if > >> anything a fix would be to rename the APCS_MSM8916 to something more > >> generic (such as QCOM_CLK_APCS_GLOBAL) - but then the content should be > >> updated and the APCS mailbox driver as well... > >=20 > > I don't see any use in being this specific. I'd prefer we just leave > > this at the ARCH_FOO config level and not try anything more fancy. >=20 > As Bjorn pointed out, why do these default "on" at all? >=20 > https://elixir.bootlin.com/linux/latest/source/drivers/clk/qcom/Kconfig >=20 > There are dozens of config knobs in drivers/clk/qcom/Kconfig > and only these two force the default. >=20 > Let's remove the default altogether. >=20 Sure.