From: Mark Brown <broonie@kernel.org>
To: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Cc: lgirdwood@gmail.com, agross@kernel.org, david.brown@linaro.org,
bjorn.andersson@linaro.org, robh+dt@kernel.org,
mark.rutland@arm.com, jorge.ramirez-ortiz@linaro.org,
niklas.cassel@linaro.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/7] drivers: regulator: qcom_spmi: enable linear range info
Date: Thu, 13 Jun 2019 19:51:36 +0100 [thread overview]
Message-ID: <20190613185136.GW5316@sirena.org.uk> (raw)
In-Reply-To: <20190606184923.39537-1-jeffrey.l.hugo@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 926 bytes --]
On Thu, Jun 06, 2019 at 11:49:23AM -0700, Jeffrey Hugo wrote:
> + if (vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_HFS430) {
> + /* since there is only one range */
> + range = spmi_regulator_find_range(vreg);
> + vreg->desc.uV_step = range->step_uV;
> + }
This doesn't build for me:
drivers/regulator/qcom_spmi-regulator.c: In function ‘qcom_spmi_regulator_probe’:
drivers/regulator/qcom_spmi-regulator.c:1837:29: error: ‘SPMI_REGULATOR_LOGICAL_TYPE_HFS430’ undeclared (first use in this function); did you mean ‘SPMI_REGULATOR_LOGICAL_TYPE_FTSMPS’?
if (vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_HFS430) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
SPMI_REGULATOR_LOGICAL_TYPE_FTSMPS
drivers/regulator/qcom_spmi-regulator.c:1837:29: note: each undeclared identifier is reported only once for each function it appears in
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-06-13 18:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 18:48 [PATCH v2 0/7] PM8005 and PMS405 regulator support Jeffrey Hugo
2019-06-06 18:49 ` [PATCH v2 1/7] drivers: regulator: qcom_spmi: enable linear range info Jeffrey Hugo
2019-06-13 18:40 ` Mark Brown
2019-06-13 18:51 ` Mark Brown [this message]
2019-06-06 18:49 ` [PATCH v2 2/7] drivers: regulator: qcom_spmi: Refactor get_mode/set_mode Jeffrey Hugo
2019-06-06 18:50 ` [PATCH v2 3/7] dt-bindings: qcom_spmi: Document PM8005 regulators Jeffrey Hugo
2019-06-06 18:50 ` [PATCH v2 4/7] regulator: qcom_spmi: Add support for PM8005 Jeffrey Hugo
2019-06-06 18:51 ` [PATCH v2 5/7] arm64: dts: msm8998-mtp: Add pm8005_s1 regulator Jeffrey Hugo
2019-06-06 18:51 ` [PATCH v2 6/7] dt-bindings: qcom_spmi: Document pms405 support Jeffrey Hugo
2019-06-06 18:51 ` [PATCH v2 7/7] drivers: regulator: qcom: add PMS405 SPMI regulator Jeffrey Hugo
2019-06-07 14:16 ` Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613185136.GW5316@sirena.org.uk \
--to=broonie@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=niklas.cassel@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).