From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@sonymobile.com>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH -next] soc: qcom: fix QCOM_AOSS_QMP dependency and build errors
Date: Fri, 14 Jun 2019 22:24:46 -0700 [thread overview]
Message-ID: <20190615052446.GA31088@tuxbook-pro> (raw)
In-Reply-To: <6d97f8dc-f980-7825-4aa6-27f56b25bc3a@infradead.org>
On Fri 14 Jun 14:47 PDT 2019, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix Kconfig warning and subsequent build errors that are caused
> when PM_GENERIC_DOMAINS=y but CONFIG_PM is not set/enabled.
>
Thanks Randy, I thought I had all angles covered here.
Applied to our -next branch.
Regards,
Bjorn
> WARNING: unmet direct dependencies detected for PM_GENERIC_DOMAINS
> Depends on [n]: PM [=n]
> Selected by [m]:
> - QCOM_AOSS_QMP [=m] && (ARCH_QCOM || COMPILE_TEST [=y]) && MAILBOX [=y] && COMMON_CLK [=y]
>
> Fixes these build errors:
>
> ../drivers/base/power/domain.c: In function ‘genpd_queue_power_off_work’:
> ../drivers/base/power/domain.c:485:13: error: ‘pm_wq’ undeclared (first use in this function)
> queue_work(pm_wq, &genpd->power_off_work);
> ../drivers/base/power/domain.c:485:13: note: each undeclared identifier is reported only once for each function it appears in
> ../drivers/base/power/domain.c: In function ‘genpd_dev_pm_qos_notifier’:
> ../drivers/base/power/domain.c:675:25: error: ‘struct dev_pm_info’ has no member named ‘ignore_children’
> if (!dev || dev->power.ignore_children)
> ../drivers/base/power/domain.c: In function ‘rtpm_status_str’:
> ../drivers/base/power/domain.c:2754:16: error: ‘struct dev_pm_info’ has no member named ‘runtime_error’
> if (dev->power.runtime_error)
> ../drivers/base/power/domain.c:2756:21: error: ‘struct dev_pm_info’ has no member named ‘disable_depth’
> else if (dev->power.disable_depth)
> ../drivers/base/power/domain.c:2758:21: error: ‘struct dev_pm_info’ has no member named ‘runtime_status’
> else if (dev->power.runtime_status < ARRAY_SIZE(status_lookup))
> ../drivers/base/power/domain.c:2759:31: error: ‘struct dev_pm_info’ has no member named ‘runtime_status’
> p = status_lookup[dev->power.runtime_status];
> ../drivers/base/power/domain_governor.c: In function ‘default_suspend_ok’:
> ../drivers/base/power/domain_governor.c:82:17: error: ‘struct dev_pm_info’ has no member named ‘ignore_children’
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Andy Gross <andy.gross@linaro.org>
> Cc: David Brown <david.brown@linaro.org>
> ---
> drivers/soc/qcom/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20190614.orig/drivers/soc/qcom/Kconfig
> +++ linux-next-20190614/drivers/soc/qcom/Kconfig
> @@ -8,7 +8,7 @@ config QCOM_AOSS_QMP
> tristate "Qualcomm AOSS Driver"
> depends on ARCH_QCOM || COMPILE_TEST
> depends on MAILBOX
> - depends on COMMON_CLK
> + depends on COMMON_CLK && PM
> select PM_GENERIC_DOMAINS
> help
> This driver provides the means of communicating with and controlling
>
>
prev parent reply other threads:[~2019-06-15 5:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 21:47 [PATCH -next] soc: qcom: fix QCOM_AOSS_QMP dependency and build errors Randy Dunlap
2019-06-15 5:24 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190615052446.GA31088@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=david.brown@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).