From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31F03C48BE4 for ; Sun, 23 Jun 2019 16:36:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 022AD206BA for ; Sun, 23 Jun 2019 16:36:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561307817; bh=bgRO7bREz2maqiR8ifkc3/2uY/Cw6hgv+ekC+zp5BUQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=yl0t/If1M+SEhmGNoYBMhmnmzRxxQeXizTLViND5JIpgERVMUq+IlC2tMCgnELDbh Vlweo0ESFyABNjGy54yQTJ9ZfFZNvmuRwJD74lgIARYpqIlIS70M400JXIPQnvCELH hLjYIsYAh84ry5ikywfF1vZT6FQY7dP8aWfOqmrA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726586AbfFWQgw (ORCPT ); Sun, 23 Jun 2019 12:36:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:50012 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726399AbfFWQgw (ORCPT ); Sun, 23 Jun 2019 12:36:52 -0400 Received: from localhost (unknown [106.201.35.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC0EE206BA; Sun, 23 Jun 2019 16:36:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561307811; bh=bgRO7bREz2maqiR8ifkc3/2uY/Cw6hgv+ekC+zp5BUQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L43njXquan/oLhDPeB4YacVyIXbcPYNsqx1NqEpiLD9ayL0nXbOkGMDMPwPQ0t5lt JF2JD1SSggQkJycI3FsciabqRuih33k5Pp+ONI1y11fE3KRkwIm/leHZZc8oQB4Fx1 MXptBbdxfVq5dsHKkthHI7u8bqabI9geamVtlHPA= Date: Sun, 23 Jun 2019 22:03:42 +0530 From: Vinod Koul To: Christian Lamparter Cc: Mathias Nyman , Greg Kroah-Hartman , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Christian Lamparter , Yoshihiro Shimoda , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/5] usb: xhci: add firmware loader for uPD720201 and uPD720202 w/o ROM Message-ID: <20190623163342.GR2962@vkoul-mobl> References: <20190621085913.8722-1-vkoul@kernel.org> <20190621085913.8722-2-vkoul@kernel.org> <1897697.zOhlaAKarQ@debian64> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1897697.zOhlaAKarQ@debian64> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 21-06-19, 21:59, Christian Lamparter wrote: > On Friday, June 21, 2019 10:59:09 AM CEST Vinod Koul wrote: > > + /* > > + * The Firmware's Data Format is describe in > > + * "6.3 Data Format" R19UH0078EJ0500 Rev.5.00 page 124 > > + */ > > + > > + /* "Each row is 8 bytes". => firmware size must be a multiple of 8. */ > > + if (length % 8 != 0) > > + dev_warn(&dev->dev, "firmware size is not a multiple of 8."); > > It doesn't look like this holds true for the newer K2026090.mem which > arguably fixes a lot of bugs over K2013080.mem. I think we should remove > this check and message. The documentation still says so, that is why I changed error return and this to warning. Yeah lets remove to not confuse folks :) -- ~Vinod